A little bug in mpeg4videoparse (plugins bad 0.10.23)

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

A little bug in mpeg4videoparse (plugins bad 0.10.23)

Matteo Pampolini
Hi all,

testing the new GStreamer release I found what it seems a little bug in mpeg4videoparse code.

In particular in source file gst-libs/gst/codecparsers/gstmpeg4parser.c at line 1017 a marker bit is expected, while ISO standard does not specify a marker bit at that stream position. This prevents the parser to go on and of course to get the rest of the information needed (width, height, etc.).

Just commenting that line fixes the problem, though a little after the parser complains on quantization matrix: at a first glance everything seems OK, but I'm not an expert on MPEG4 syntax, so I think a check is needed, that's why I preferred to write in the mailing list instead of directly committing the fix.

Many thanks for your attention,

Matteo

 

_______________________________________________
gstreamer-devel mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/gstreamer-devel
Reply | Threaded
Open this post in threaded view
|

Re: A little bug in mpeg4videoparse (plugins bad 0.10.23)

Tim-Philipp Müller-2
On Mon, 2012-03-19 at 17:28 +0100, Matteo Pampolini wrote:

Hi Matteo,

> testing the new GStreamer release I found what it seems a little bug
> in mpeg4videoparse code.
>
> In particular in source file
> gst-libs/gst/codecparsers/gstmpeg4parser.c at line 1017 a marker bit
> is expected, while ISO standard does not specify a marker bit at that
> stream position. This prevents the parser to go on and of course to
> get the rest of the information needed (width, height, etc.).
>
> Just commenting that line fixes the problem, though a little after the
> parser complains on quantization matrix: at a first glance everything
> seems OK, but I'm not an expert on MPEG4 syntax, so I think a check is
> needed, that's why I preferred to write in the mailing list instead of
> directly committing the fix.

could you file a bug in bugzilla please, so we don't forget about it?

http://gstreamer.freedesktop.org/bugs/

Cheers
 -Tim

_______________________________________________
gstreamer-devel mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/gstreamer-devel