About some code segments in hdv1394src plugin

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

About some code segments in hdv1394src plugin

liangzhihong1984
Hi, everyone.
I was learning how to write a plugin.
when I study the source code of hdv1394src, some code really confused me.
 
  if (iec61883_mpeg2_recv_start (src->iec61883mpeg2, src->channel) != 0)
    goto cannot_start;
#if 0
  if (raw1394_start_iso_rcv (src->handle, src->channel) < 0)
    goto cannot_start;
#endif
 
So when should I use the iec61883_mpeg2_recv_start and when should raw1394_start_iso_rcv, can anybody explain?
 
Thank you in advance.
Best Regards,
Leon Liang



网易邮箱,中国第一大电子邮件服务商

------------------------------------------------------------------------------

_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gstreamer-devel
Reply | Threaded
Open this post in threaded view
|

Re: About some code segments in hdv1394src plugin

Edward Hervey
Administrator
Hi,

On Mon, 2009-03-30 at 13:55 +0800, liangzhihong1984 wrote:

> Hi, everyone.
> I was learning how to write a plugin.
> when I study the source code of hdv1394src, some code really confused
> me.
>  
>   if (iec61883_mpeg2_recv_start (src->iec61883mpeg2, src->channel) !=
> 0)
>     goto cannot_start;
> #if 0
>   if (raw1394_start_iso_rcv (src->handle, src->channel) < 0)
>     goto cannot_start;
> #endif
>  
> So when should I use the iec61883_mpeg2_recv_start and when should
> raw1394_start_iso_rcv, can anybody explain?

  raw1394_start_iso_rcv is for the lowest-level handling of firewire
data. But since we *know* we only are going to receive HDV we can use
the higher-level methods (iec61882). The '#if 0'd code is dead code.

   Edward

>  
> Thank you in advance.
> Best Regards,
> Leon Liang
>
>
>
>
> ______________________________________________________________________
> 网易邮箱,中国第一大电子邮件服务商
> ------------------------------------------------------------------------------
> _______________________________________________
> gstreamer-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/gstreamer-devel


------------------------------------------------------------------------------
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gstreamer-devel