Felipe Contreras : util: Fix for allocate buffer.

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Felipe Contreras : util: Fix for allocate buffer.

Felipe Contreras-3
Module: gst-openmax
Branch: master
Commit: 10c238e8a34c4693a742f596faec4efe2185ea77
URL:    http://cgit.freedesktop.org/gstreamer/gst-openmax/commit/?id=10c238e8a34c4693a742f596faec4efe2185ea77

Author: Felipe Contreras <[hidden email]>
Date:   Wed Dec 10 18:58:03 2008 +0200

util: Fix for allocate buffer.

The buffer shall be freed only when allocated by us as opposed to some
other element.

Signed-off-by: Felipe Contreras <[hidden email]>

---

 omx/gstomx_util.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/omx/gstomx_util.c b/omx/gstomx_util.c
index 429d47a..1b34b9b 100644
--- a/omx/gstomx_util.c
+++ b/omx/gstomx_util.c
@@ -505,10 +505,11 @@ port_free_buffers (GOmxPort *port)
 
         if (omx_buffer)
         {
-#ifdef USE_ALLOCATE_BUFFER
+#if 0
+            /** @todo how shall we free that buffer? */
             g_free (omx_buffer->pBuffer);
             omx_buffer->pBuffer = NULL;
-#endif /* USE_ALLOCATE_BUFFER */
+#endif
 
             OMX_FreeBuffer (port->core->omx_handle, port->port_index, omx_buffer);
             port->buffers[i] = NULL;


------------------------------------------------------------------------------
Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
-OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
-Strategies to boost innovation and cut costs with open source participation
-Receive a $600 discount off the registration fee with the source code: SFAD
http://p.sf.net/sfu/XcvMzF8H
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gstreamer-devel
Reply | Threaded
Open this post in threaded view
|

Re: Felipe Contreras : util: Fix for allocate buffer.

Felipe Contreras
On Wed, Feb 4, 2009 at 11:24 PM, Felipe Contreras
<[hidden email]> wrote:

> Module: gst-openmax
> Branch: master
> Commit: 10c238e8a34c4693a742f596faec4efe2185ea77
> URL:    http://cgit.freedesktop.org/gstreamer/gst-openmax/commit/?id=10c238e8a34c4693a742f596faec4efe2185ea77
>
> Author: Felipe Contreras <[hidden email]>
> Date:   Wed Dec 10 18:58:03 2008 +0200
>
> util: Fix for allocate buffer.
>
> The buffer shall be freed only when allocated by us as opposed to some
> other element.
>
> Signed-off-by: Felipe Contreras <[hidden email]>

Please disregard these messages. It was a local test for the git hook
that somehow got queued and sent now.

--
Felipe Contreras

------------------------------------------------------------------------------
Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
-OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
-Strategies to boost innovation and cut costs with open source participation
-Receive a $600 discount off the registration fee with the source code: SFAD
http://p.sf.net/sfu/XcvMzF8H
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gstreamer-devel