GstBaseParse - segment

[Julien Isorce]

Hi

In line 1080 of gstbaseparse.c from  http://cgit.freedesktop.org/gstreamer/gst-plugins-bad/tree/gst/audioparsers/gstbaseparse.c :

parse->pending_segment = gst_event_new_new_segment (FALSE, parse->segment.rate,

        parse->segment.format, last_start, -1, last_start);

I think the 'update' parameter 'of gst_event_new_new_segment' should be TRUE because we are in the case where there was an existing pending_segment.
If I'm wrong, could someone explain me ?


Regards

Julien

------------------------------------------------------------------------------
The Palm PDK Hot Apps Program offers developers who use the
Plug-In Development Kit to bring their C/C++ apps to Palm for a share
of $1 Million in cash or HP Products. Visit us here for more details:
http://p.sf.net/sfu/dev2dev-palm
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gstreamer-devel

[Mark Nauwelaerts]

Julien Isorce wrote:

> |Hi|
>
>
> |In line 1080 of gstbaseparse.c from|http://cgit.freedesktop.org/gstreamer/gst-plugins-bad/tree/gst/audioparsers/gstbaseparse.c  :
>
>
> parse->pending_segment = gst_event_new_new_segment (FALSE, parse->segment.rate,
>
> |         parse->segment.format, last_start, -1, last_start);|
>
> |
> |
>
> |I think the'update'  parameter'of gst_event_new_new_segment'  should be TRUE because we are in the case where there was an existing pending_segment.
> |
>
> If I'm wrong, could someone explain me ?

An existing (internal) pending_segment means that a new_segment event still has
to be sent, and more than likely downstream has not yet seen any new_segment
(since last FLUSH or so at least).  The internal new_segment is being updated
here before it is sent downstream, so it is not an update w.r.t. one sent earlier.

Mark.

------------------------------------------------------------------------------
The Palm PDK Hot Apps Program offers developers who use the
Plug-In Development Kit to bring their C/C++ apps to Palm for a share
of $1 Million in cash or HP Products. Visit us here for more details:
http://p.sf.net/sfu/dev2dev-palm
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gstreamer-devel