Gstreamer RTSP server - finalize() doesn't delete io_channel watches...

[Matthias Dodt]

Hey guys!

I think the RTSP Server is missing some code in the finalize method. The
underlying IO channel doesn't get deleted (close is not called on the
socket) which prevents the server from running correctly after the
object has been destroyed and newly created once. I guess the watch on
the IO channel should be deleted and the refcount of the iochannel must
be decremented:

gst_rtsp_server_finalize (GObject *object)
{

...
//remove the io-watch
if(g_source_remove(server->io_watch)
{
        g_source_unref(server->io_watch);
}
else
{
        GST_ERROR_OBJECT (server, "failed to remove io watch");
}

//io channel should be deleted...
g_io_channel_unref(server->io_channel);
...

}

Feel free to add the code in future versions,

Cheers

mat
_______________________________________________
gstreamer-devel mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/gstreamer-devel

[Tim-Philipp Müller-2]

On Thu, 2011-09-29 at 11:48 +0200, Matthias Dodt wrote:

Hi Matthias,

> I think the RTSP Server is missing some code in the finalize method. The
> underlying IO channel doesn't get deleted (close is not called on the
> socket) which prevents the server from running correctly after the
> object has been destroyed and newly created once. I guess the watch on
> the IO channel should be deleted and the refcount of the iochannel must
> be decremented:
>
> (snip)

Could you file a bug in bugzilla [0] please, so it's not forgotten
about?

Cheers
 -Tim

[0] http://gstreamer.freedesktop.org/bugs/



_______________________________________________
gstreamer-devel mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/gstreamer-devel

[Matthias Dodt]

Ok, done!

cheers

-----Ursprüngliche Nachricht-----
Von: gstreamer-devel-bounces+mdodt=[hidden email] [mailto:gstreamer-devel-bounces+mdodt=[hidden email]] Im Auftrag von Tim-Philipp Müller
Gesendet: 29 September 2011 12:21
An: [hidden email]
Betreff: Re: Gstreamer RTSP server - finalize() doesn't delete io_channelwatches...

On Thu, 2011-09-29 at 11:48 +0200, Matthias Dodt wrote:

Hi Matthias,

> I think the RTSP Server is missing some code in the finalize method.
> The underlying IO channel doesn't get deleted (close is not called on
> the
> socket) which prevents the server from running correctly after the
> object has been destroyed and newly created once. I guess the watch on
> the IO channel should be deleted and the refcount of the iochannel
> must be decremented:
>
> (snip)

Could you file a bug in bugzilla [0] please, so it's not forgotten about?

Cheers
 -Tim

[0] http://gstreamer.freedesktop.org/bugs/



_______________________________________________
gstreamer-devel mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/gstreamer-devel



_______________________________________________
gstreamer-devel mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/gstreamer-devel