I don't understand this bug fix from years ago

[Ben Rush]

https://sourceforge.net/p/gstreamer/mailman/message/26689776/ 

That's the conversation about the bug, and here's the line: 

https://github.com/GStreamer/gstreamer/blob/master/gst/gsttask.c#L134  

The reason this is done is: 

https://docs.microsoft.com/en-us/visualstudio/debugger/how-to-set-a-thread-name-in-native-code?view=vs-2019 

It's manually tossing an exception (RaiseException). But we can use SetThreadDescription now in 2017+. I get that it's important to support older versions of Visual Studio, but if it's only valuable for them while debugging, why not wrap it in  https://docs.microsoft.com/en-us/windows/win32/api/debugapi/nf-debugapi-isdebuggerpresent?redirectedfrom=MSDN? In all other crashing instances, this method isn't valuable. 

The problem is that when you register a global error watcher via vectored exception handling, this error floods your logs regardless of whether it's caught. I can filter by  0x406D1388, but I argue it's not really a good thing to do. Also: it's not as useful as SetThreadDescription for us using more modern versions of VS and Windows. 

Does anybody know any history behind this besides what I've found? 

_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/gstreamer-devel

[Tim Müller]

On Mon, 2019-09-23 at 10:08 -0500, Ben Rush wrote:

Hi Ben,

I wouldn't attribute too much weight or read too much into something MSVC-specific done 9 years ago.

If you think there's a better way of doing this now, please file an issue (or better, a Merge Request) in gitlab, which is the best place to discuss improvements, and makes sure it doesn't get lost.

Cheers

Tim

-- 

Tim Müller, Centricular Ltd - http://www.centricular.com

Join us at the GStreamer Conference! 31 Oct-1 Nov 2019 in Lyon, France

_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/gstreamer-devel

[Ben Rush]

Thanks, Tim, I will do that. 

I was asking because I'm still new around here and didn't want to step on toes or just miss something obvious. 

Thanks again. 

On Mon, Sep 23, 2019 at 10:17 AM Tim Müller <[hidden email]> wrote:

On Mon, 2019-09-23 at 10:08 -0500, Ben Rush wrote:

Hi Ben,

I wouldn't attribute too much weight or read too much into something MSVC-specific done 9 years ago.

If you think there's a better way of doing this now, please file an issue (or better, a Merge Request) in gitlab, which is the best place to discuss improvements, and makes sure it doesn't get lost.

Cheers

Tim

-- 

Tim Müller, Centricular Ltd - http://www.centricular.com

Join us at the GStreamer Conference! 31 Oct-1 Nov 2019 in Lyon, France

_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/gstreamer-devel

_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/gstreamer-devel

[Nirbheek Chauhan]

It would probably be worth making the same changes upstream in GLib
too, which uses the same old code too:
https://gitlab.gnome.org/GNOME/glib/blob/master/glib/gthread-win32.c#L506

On Mon, Sep 23, 2019 at 8:55 PM Ben Rush <[hidden email]> wrote:

>
> Thanks, Tim, I will do that.
>
> I was asking because I'm still new around here and didn't want to step on toes or just miss something obvious.
>
> Thanks again.
>
> On Mon, Sep 23, 2019 at 10:17 AM Tim Müller <[hidden email]> wrote:
>>
>> On Mon, 2019-09-23 at 10:08 -0500, Ben Rush wrote:
>>
>> Hi Ben,
>>
>> I wouldn't attribute too much weight or read too much into something MSVC-specific done 9 years ago.
>>
>> If you think there's a better way of doing this now, please file an issue (or better, a Merge Request) in gitlab, which is the best place to discuss improvements, and makes sure it doesn't get lost.
>>
>> Cheers
>> Tim
>>
>> --
>>
>> Tim Müller, Centricular Ltd - http://www.centricular.com
>>
>> Join us at the GStreamer Conference! 31 Oct-1 Nov 2019 in Lyon, France
>> _______________________________________________
>> gstreamer-devel mailing list
>> [hidden email]
>> https://lists.freedesktop.org/mailman/listinfo/gstreamer-devel
>
> _______________________________________________
> gstreamer-devel mailing list
> [hidden email]
> https://lists.freedesktop.org/mailman/listinfo/gstreamer-devel

_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/gstreamer-devel

[Ben Rush]

Yeah. I plan on getting to that this week. 

On Mon, Sep 23, 2019 at 1:10 PM Nirbheek Chauhan <[hidden email]> wrote:

It would probably be worth making the same changes upstream in GLib
too, which uses the same old code too:
https://gitlab.gnome.org/GNOME/glib/blob/master/glib/gthread-win32.c#L506

On Mon, Sep 23, 2019 at 8:55 PM Ben Rush <[hidden email]> wrote:
>
> Thanks, Tim, I will do that.
>
> I was asking because I'm still new around here and didn't want to step on toes or just miss something obvious.
>
> Thanks again.
>
> On Mon, Sep 23, 2019 at 10:17 AM Tim Müller <[hidden email]> wrote:
>>
>> On Mon, 2019-09-23 at 10:08 -0500, Ben Rush wrote:
>>
>> Hi Ben,
>>
>> I wouldn't attribute too much weight or read too much into something MSVC-specific done 9 years ago.
>>
>> If you think there's a better way of doing this now, please file an issue (or better, a Merge Request) in gitlab, which is the best place to discuss improvements, and makes sure it doesn't get lost.
>>
>> Cheers
>> Tim
>>
>> --
>>
>> Tim Müller, Centricular Ltd - http://www.centricular.com
>>
>> Join us at the GStreamer Conference! 31 Oct-1 Nov 2019 in Lyon, France
>> _______________________________________________
>> gstreamer-devel mailing list
>> [hidden email]
>> https://lists.freedesktop.org/mailman/listinfo/gstreamer-devel
>
> _______________________________________________
> gstreamer-devel mailing list
> [hidden email]
> https://lists.freedesktop.org/mailman/listinfo/gstreamer-devel
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/gstreamer-devel

_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/gstreamer-devel