MPEGTS Extended Event documentation

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

MPEGTS Extended Event documentation

Russel Winder
Hi,

https://gstreamer.freedesktop.org/documentation/mpegts/gst-atsc-descriptor.html?gi-language=c#GstMpegtsExtendedEventDescriptor

says that the language_code field of GstMpegtsExtendedEventDescriptor is "NULL
terminated language code."

Having investigated this with code I beg to disagree, ii is a 3 character
array with no null anywhere.

--
Russel.
===========================================
Dr Russel Winder      t: +44 20 7585 2200
41 Buckmaster Road    m: +44 7770 465 077
London SW11 1EN, UK   w: www.russel.org.uk


_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/gstreamer-devel

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: MPEGTS Extended Event documentation

Nicolas Dufresne-5


Le dim. 7 juill. 2019 15 h 10, Russel Winder <[hidden email]> a écrit :
Hi,

https://gstreamer.freedesktop.org/documentation/mpegts/gst-atsc-descriptor.html?gi-language=c#GstMpegtsExtendedEventDescriptor

says that the language_code field of GstMpegtsExtendedEventDescriptor is "NULL
terminated language code."

Having investigated this with code I beg to disagree, ii is a 3 character
array with no null anywhere.

Best is to open an issue in gitlab. We can then decide if we make it null terminated or not.


--
Russel.
===========================================
Dr Russel Winder      t: +44 20 7585 2200
41 Buckmaster Road    m: +44 7770 465 077
London SW11 1EN, UK   w: www.russel.org.uk

_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/gstreamer-devel

_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/gstreamer-devel
Reply | Threaded
Open this post in threaded view
|

Re: MPEGTS Extended Event documentation

Russel Winder
On Sun, 2019-07-07 at 16:25 -0400, Nicolas Dufresne wrote:
>
[…]
> Best is to open an issue in gitlab. We can then decide if we make it null
> terminated or not.
[…]

Hummm… I think there was a wetware error in the data collection of last
evening, so there is no hard data on the problem as yet. More work needed, but
if the problem is real, I'll switch to reporting a bug properly.

--
Russel.
===========================================
Dr Russel Winder      t: +44 20 7585 2200
41 Buckmaster Road    m: +44 7770 465 077
London SW11 1EN, UK   w: www.russel.org.uk


_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/gstreamer-devel

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: MPEGTS Extended Event documentation

Tim Müller
On Mon, 2019-07-08 at 09:36 +0100, Russel Winder wrote:


> Hummm… I think there was a wetware error in the data collection of
> last evening, so there is no hard data on the problem as yet. More
> work needed, but if the problem is real, I'll switch to reporting a
> bug properly.

Just to be sure, I'm 99% sure that what is meant here is that the
string is/should be terminated by a 0 character (NUL), not a NULL
pointer, in case that's the point of confusion.

Cheers
 Tim

--
Tim Müller, Centricular Ltd - http://www.centricular.com

_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/gstreamer-devel
Reply | Threaded
Open this post in threaded view
|

Re: MPEGTS Extended Event documentation

Russel Winder
On Mon, 2019-07-08 at 09:51 +0100, Tim Müller wrote:
> […]
>
> Just to be sure, I'm 99% sure that what is meant here is that the
> string is/should be terminated by a 0 character (NUL), not a NULL
> pointer, in case that's the point of confusion.
>

For now I am making that assumption, the problem was my test data was wrong.

The actual problem of the moment is that doesn't appear to be a struct to
represent a short event in the Rust sys wrapper for the MPEG-TS library, there
is one for the extended event
(gstreamer_mpegts_sys::GstMpegtsExtendedEventDescriptor), but I cannot find
one for a short event. I am hoping I have just failed to see it, but searching
the lib.rs there is nothing associate with a short event to be found.

--
Russel.
===========================================
Dr Russel Winder      t: +44 20 7585 2200
41 Buckmaster Road    m: +44 7770 465 077
London SW11 1EN, UK   w: www.russel.org.uk


_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/gstreamer-devel

signature.asc (849 bytes) Download Attachment