[PATCH] Move AM_CONDITIONAL(HAVE_DSSIM) outside of if the iqa check block

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] Move AM_CONDITIONAL(HAVE_DSSIM) outside of if the iqa check block

Lars Wendler
or else configure fails with

  error: conditional "HAVE_DSSIM" was never defined.

when iqa is not installed.
---
 configure.ac | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index 92411b194..185b49f48 100644
--- a/configure.ac
+++ b/configure.ac
@@ -359,13 +359,13 @@ AG_GST_CHECK_FEATURE(IQA, [iqa], iqa , [
     HAVE_IQA="no"
   ])
 
-  AM_CONDITIONAL(HAVE_DSSIM, test "x$HAVE_DSSIM" = "xyes")
   if test "x$HAVE_DSSIM" = "xyes"; then
     AC_DEFINE(HAVE_DSSIM, 1, [Define if you have dssim library])
   fi
   AC_SUBST(DSSIM_LIBS)
   AC_SUBST(DSSIM_CFLAGS)
 ])
+AM_CONDITIONAL(HAVE_DSSIM, test "x$HAVE_DSSIM" = "xyes")
 
 dnl Orc
 ORC_CHECK([0.4.17])
--
2.11.0

_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/gstreamer-devel
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Move AM_CONDITIONAL(HAVE_DSSIM) outside of if the iqa check block

Sebastian Dröge-3
On Sat, 2017-01-21 at 03:03 +0100, Lars Wendler wrote:
> or else configure fails with
>
>   error: conditional "HAVE_DSSIM" was never defined.
>
> when iqa is not installed.

Thanks for your patch, but we track patches in Bugzilla.
See here for details:
  https://gstreamer.freedesktop.org/documentation/contribute/#how-to-submit-patches

--
Sebastian Dröge, Centricular Ltd · http://www.centricular.com
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/gstreamer-devel

signature.asc (981 bytes) Download Attachment