[PATCH] pulsesink: Fix a couple error messages that mentioned incorrect function names.

[Colin Guthrie-6]

I just happened to notice these when looking at the errors produced
rather than a code review, so others may exist still :)

Signed-off-by: Colin Guthrie <[hidden email]>
---
  ext/pulse/pulsesink.c |    4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)



--

Colin Guthrie
gmane(at)colin.guthr.ie
http://colin.guthr.ie/

Day Job:
   Tribalogic Limited [http://www.tribalogic.net/]
Open Source:
   Mandriva Linux Contributor [http://www.mandriva.com/]
   PulseAudio Hacker [http://www.pulseaudio.org/]
   Trac Hacker [http://trac.edgewall.org/]

diff --git a/ext/pulse/pulsesink.c b/ext/pulse/pulsesink.c
index d80d5cf..fbaac8c 100644
--- a/ext/pulse/pulsesink.c
+++ b/ext/pulse/pulsesink.c
@@ -1716,7 +1716,7 @@ no_buffer:
 info_failed:
   {
     GST_ELEMENT_ERROR (psink, RESOURCE, FAILED,
-        ("pa_stream_get_sink_input_info() failed: %s",
+        ("pa_context_get_sink_input_info() failed: %s",
             pa_strerror (pa_context_errno (pbuf->context))), (NULL));
     goto unlock;
   }
@@ -1789,7 +1789,7 @@ no_buffer:
 info_failed:
   {
     GST_ELEMENT_ERROR (psink, RESOURCE, FAILED,
-        ("pa_stream_get_sink_info() failed: %s",
+        ("pa_context_get_sink_info_by_index() failed: %s",
             pa_strerror (pa_context_errno (pbuf->context))), (NULL));
     goto unlock;
   }


------------------------------------------------------------------------------

_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gstreamer-devel

[Philip Jägenstedt]

Patches and bug reports belong in Bugzilla, not on the mailing list.

http://bugzilla.gnome.org/enter_bug.cgi?product=GStreamer

On Wed, Jul 22, 2009 at 13:43, Colin Guthrie<[hidden email]> wrote:

>
> I just happened to notice these when looking at the errors produced rather
> than a code review, so others may exist still :)
>
> Signed-off-by: Colin Guthrie <[hidden email]>
> ---
>  ext/pulse/pulsesink.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
>
>
> --
>
> Colin Guthrie
> gmane(at)colin.guthr.ie
> http://colin.guthr.ie/
>
> Day Job:
>  Tribalogic Limited [http://www.tribalogic.net/]
> Open Source:
>  Mandriva Linux Contributor [http://www.mandriva.com/]
>  PulseAudio Hacker [http://www.pulseaudio.org/]
>  Trac Hacker [http://trac.edgewall.org/]
>
> ------------------------------------------------------------------------------
>
> _______________________________________________
> gstreamer-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/gstreamer-devel
>
>

--
Philip Jägenstedt

------------------------------------------------------------------------------
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gstreamer-devel

[Colin Guthrie-6]

'Twas brillig, and Philip Jägenstedt at 22/07/09 22:07 did gyre and gimble:
> Patches and bug reports belong in Bugzilla, not on the mailing list.
>
> http://bugzilla.gnome.org/enter_bug.cgi?product=GStreamer

How weird. I thought after the switch to git you'd be happy to accept
patches in the same way as every other project using git - I mean that's
the whole point in git send-mail and git am.

Ahh well take it or leave it, it's hardly a critical problem worth
spending much time on :)

Col

--

Colin Guthrie
gmane(at)colin.guthr.ie
http://colin.guthr.ie/

Day Job:
   Tribalogic Limited [http://www.tribalogic.net/]
Open Source:
   Mandriva Linux Contributor [http://www.mandriva.com/]
   PulseAudio Hacker [http://www.pulseaudio.org/]
   Trac Hacker [http://trac.edgewall.org/]


------------------------------------------------------------------------------
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gstreamer-devel

[Bastien Nocera-2]

On Wed, 2009-07-22 at 22:47 +0100, Colin Guthrie wrote:
> 'Twas brillig, and Philip Jägenstedt at 22/07/09 22:07 did gyre and gimble:
> > Patches and bug reports belong in Bugzilla, not on the mailing list.
> >
> > http://bugzilla.gnome.org/enter_bug.cgi?product=GStreamer
>
> How weird. I thought after the switch to git you'd be happy to accept
> patches in the same way as every other project using git - I mean that's
> the whole point in git send-mail and git am.

That's a kernel tool, use git bz for GStreamer...

> Ahh well take it or leave it, it's hardly a critical problem worth
> spending much time on :)
>
> Col
>


------------------------------------------------------------------------------
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gstreamer-devel

[Colin Guthrie-6]

'Twas brillig, and Bastien Nocera at 22/07/09 23:08 did gyre and gimble:

> On Wed, 2009-07-22 at 22:47 +0100, Colin Guthrie wrote:
>> 'Twas brillig, and Philip Jägenstedt at 22/07/09 22:07 did gyre and gimble:
>>> Patches and bug reports belong in Bugzilla, not on the mailing list.
>>>
>>> http://bugzilla.gnome.org/enter_bug.cgi?product=GStreamer
>> How weird. I thought after the switch to git you'd be happy to accept
>> patches in the same way as every other project using git - I mean that's
>> the whole point in git send-mail and git am.
>
> That's a kernel tool, use git bz for GStreamer...

Git's got a tool for *everything*. Despite the triviality of this patch
I may as well learn a new git command :p

Col

--

Colin Guthrie
gmane(at)colin.guthr.ie
http://colin.guthr.ie/

Day Job:
   Tribalogic Limited [http://www.tribalogic.net/]
Open Source:
   Mandriva Linux Contributor [http://www.mandriva.com/]
   PulseAudio Hacker [http://www.pulseaudio.org/]
   Trac Hacker [http://trac.edgewall.org/]


------------------------------------------------------------------------------
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gstreamer-devel

[Colin Guthrie-6]

'Twas brillig, and Colin Guthrie at 23/07/09 08:56 did gyre and gimble:

> 'Twas brillig, and Bastien Nocera at 22/07/09 23:08 did gyre and gimble:
>> On Wed, 2009-07-22 at 22:47 +0100, Colin Guthrie wrote:
>>> 'Twas brillig, and Philip Jägenstedt at 22/07/09 22:07 did gyre and gimble:
>>>> Patches and bug reports belong in Bugzilla, not on the mailing list.
>>>>
>>>> http://bugzilla.gnome.org/enter_bug.cgi?product=GStreamer
>>> How weird. I thought after the switch to git you'd be happy to accept
>>> patches in the same way as every other project using git - I mean that's
>>> the whole point in git send-mail and git am.
>> That's a kernel tool, use git bz for GStreamer...
>
> Git's got a tool for *everything*. Despite the triviality of this patch
> I may as well learn a new git command :p

Hmm, the script I found:

http://blog.fishsoup.net/2008/11/16/git-bz-bugzilla-subcommand-for-git/

Didn't let me file a new bug, just gave an "Internal Error" message :(

But it let me attach just fine.
http://bugzilla.gnome.org/show_bug.cgi?id=589459

Col

--

Colin Guthrie
gmane(at)colin.guthr.ie
http://colin.guthr.ie/

Day Job:
   Tribalogic Limited [http://www.tribalogic.net/]
Open Source:
   Mandriva Linux Contributor [http://www.mandriva.com/]
   PulseAudio Hacker [http://www.pulseaudio.org/]
   Trac Hacker [http://trac.edgewall.org/]


------------------------------------------------------------------------------
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gstreamer-devel