Patch review: eliminate duplicate GstMixerTrack names

[Sam Morris]

I've had a couple of patches attached to
<http://bugzilla.gnome.org/show_bug.cgi?id=528299> for a couple of
months now. Could someone please take a look at them?

They prevent two GstMixerTracks from having the same name--which is a
problem on my laptop: I have six tracks, three of which are called
"Input Source", and three of which are called "Capture". Without the
patch, gnome-volume-control can't tell the difference between them,
meaning that a user who wants to record sound has to fall back to using
alsamixer rather than gnome-volume-control.

--
Sam Morris
http://robots.org.uk/

PGP key id 1024D/5EA01078
3412 EA18 1277 354B 991B  C869 B219 7FDB 5EA0 1078

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gstreamer-devel

[Bastien Nocera-2]

On Sat, 2008-06-14 at 18:42 +0100, Sam Morris wrote:

> I've had a couple of patches attached to
> <http://bugzilla.gnome.org/show_bug.cgi?id=528299> for a couple of
> months now. Could someone please take a look at them?
>
> They prevent two GstMixerTracks from having the same name--which is a
> problem on my laptop: I have six tracks, three of which are called
> "Input Source", and three of which are called "Capture". Without the
> patch, gnome-volume-control can't tell the difference between them,
> meaning that a user who wants to record sound has to fall back to using
> alsamixer rather than gnome-volume-control.

Really, I'd rather you filed a bug against the kernel, and nicely asked
your ALSA developers to look at unbreaking the driver's labels, rather
than adding more special casing in GStreamer or gnome-volume-control...

Cheers


-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gstreamer-devel

[Sam Morris]

On Thu, 2008-06-19 at 10:57 +0100, Bastien Nocera wrote:

> On Sat, 2008-06-14 at 18:42 +0100, Sam Morris wrote:
> > I've had a couple of patches attached to
> > <http://bugzilla.gnome.org/show_bug.cgi?id=528299> for a couple of
> > months now. Could someone please take a look at them?
> >
> > They prevent two GstMixerTracks from having the same name--which is a
> > problem on my laptop: I have six tracks, three of which are called
> > "Input Source", and three of which are called "Capture". Without the
> > patch, gnome-volume-control can't tell the difference between them,
> > meaning that a user who wants to record sound has to fall back to using
> > alsamixer rather than gnome-volume-control.
>
> Really, I'd rather you filed a bug against the kernel, and nicely asked
> your ALSA developers to look at unbreaking the driver's labels, rather
> than adding more special casing in GStreamer or gnome-volume-control...

That's possible, but since there is already code in GstMixerTrack to
handle duplicate translated names it seemed logical to apply this
solution to handle untranslated names and also translated/untranslated
names of GstMixerOptions.

I get the feeling the ALSA developers do not consider this a problem;
the alsa-utils such as alsamixer already correctly handle the situation
by displaying the tracks to the user with the names "Capture", "Capture
1", "Capture 2".

Output from 'amixer controls':

        numid=16,iface=MIXER,name='Input Source'
        numid=17,iface=MIXER,name='Input Source',index=1
        numid=18,iface=MIXER,name='Input Source',index=2

But I can always ask. I'd just prefer to not have to wait until 2.6.28
for this laptop to be usable. :(

>
> Cheers
>
--
Sam Morris <[hidden email]>

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gstreamer-devel

[Bastien Nocera-2]

On Thu, 2008-06-19 at 11:22 +0100, Sam Morris wrote:
<snip>

> That's possible, but since there is already code in GstMixerTrack to
> handle duplicate translated names it seemed logical to apply this
> solution to handle untranslated names and also translated/untranslated
> names of GstMixerOptions.
>
> I get the feeling the ALSA developers do not consider this a problem;
> the alsa-utils such as alsamixer already correctly handle the situation
> by displaying the tracks to the user with the names "Capture", "Capture
> 1", "Capture 2".
>
> Output from 'amixer controls':
>
>         numid=16,iface=MIXER,name='Input Source'
>         numid=17,iface=MIXER,name='Input Source',index=1
>         numid=18,iface=MIXER,name='Input Source',index=2
>
> But I can always ask. I'd just prefer to not have to wait until 2.6.28
> for this laptop to be usable. :(

Or you could simplify the code to use the index provided instead, if
it's already available directly from ALSA. Rather than checking for
dupes by hand.


-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gstreamer-devel

[Bastien Nocera-2]

On Thu, 2008-06-19 at 11:28 +0100, Bastien Nocera wrote:

> On Thu, 2008-06-19 at 11:22 +0100, Sam Morris wrote:
> <snip>
> > That's possible, but since there is already code in GstMixerTrack to
> > handle duplicate translated names it seemed logical to apply this
> > solution to handle untranslated names and also translated/untranslated
> > names of GstMixerOptions.
> >
> > I get the feeling the ALSA developers do not consider this a problem;
> > the alsa-utils such as alsamixer already correctly handle the situation
> > by displaying the tracks to the user with the names "Capture", "Capture
> > 1", "Capture 2".
> >
> > Output from 'amixer controls':
> >
> >         numid=16,iface=MIXER,name='Input Source'
> >         numid=17,iface=MIXER,name='Input Source',index=1
> >         numid=18,iface=MIXER,name='Input Source',index=2
> >
> > But I can always ask. I'd just prefer to not have to wait until 2.6.28
> > for this laptop to be usable. :(
>
> Or you could simplify the code to use the index provided instead, if
> it's already available directly from ALSA. Rather than checking for
> dupes by hand.

I've updated the bugzilla.

The idea is right, but the implementation breaks translations, default
visible tracks, and modifies the prototype for a function needlessly.

Simply adding an index property on the element should be enough, as long
as it's followed by the necessary changes in gnome-volume-control and
the mixer-applet/control-center.


-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gstreamer-devel