Question on x264enc, modification in function "gst_x264_enc_header_buf"

[yiliang]

Hi,

The following part in the function "gst_x264_enc_header_buf" is changed in the latest release of gst-plugin-ugly.

From:

  buffer[0] = 1;                /* AVC Decoder Configuration Record ver. 1 */
  buffer[1] = sps[0];           /* profile_idc                             */
  buffer[2] = sps[1];           /* profile_compability                     */
  buffer[3] = sps[2];           /* level_idc                               */
  buffer[4] = 0xfc | (4 - 1);   /* nal_length_size_minus1                  */

To:

  buffer[0] = 1;                /* AVC Decoder Configuration Record ver. 1 */
  buffer[1] = sps[1];           /* profile_idc                             */
  buffer[2] = sps[2];           /* profile_compability                     */
  buffer[3] = sps[3];           /* level_idc                               */
  buffer[4] = 0xfc | (4 - 1);   /* nal_length_size_minus1                  */

Ubuntu uses libx264 of build 67. At least for this version, I think the original implementation was right. I do not understand why it was changed. Please help.

Thanks,
Yiliang