RTCP APP packet sent as Sender Report report block

Hello!

I would like to receive an "on-app-rtcp" callback from the rtpsession when an APP packet is received by my RTSP client. From Wireshark, I see that the server sends a SR which includes an SDES and an APP block. Looking at the code, GStreamer treats the SDES and APP as report blocks, and it doesn't trigger the "on-app-rtcp" signal.  That signal is only triggered for a separate APP packet.

I suppose one solution is to handle the raw RTCP packet callback, and parse APP myself, but would it be useful to add this handling to GStreamer report block code so we don't need to look at raw packet ?

Cheers,

Aaron

_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/gstreamer-devel

[Sebastian Dröge-3]

On Tue, 2019-06-18 at 21:46 -0400, Aaron Boxer wrote:

> Hello!
>
> I would like to receive an "on-app-rtcp" callback from the rtpsession
> when an APP packet is received by my RTSP client. From Wireshark, I
> see that the server sends a SR which includes an SDES and an APP
> block. Looking at the code, GStreamer treats the SDES and APP as
> report blocks, and it doesn't trigger the "on-app-rtcp" signal.  That
> signal is only triggered for a separate APP packet.
>
> I suppose one solution is to handle the raw RTCP packet callback, and
> parse APP myself, but would it be useful to add this handling to
> GStreamer report block code so we don't need to look at raw packet ?

Please create an issue for this :) Or even better an MR that implements
what you're suggesting. Intuitively I would've also expected the signal
to trigger whenever there's an APP RTCP packet, no matter in which
context it appears.

--
Sebastian Dröge, Centricular Ltd · https://www.centricular.com


_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/gstreamer-devel

[Nicolas Dufresne-5]

Le mer. 19 juin 2019 01 h 40, Sebastian Dröge <[hidden email]> a écrit :

On Tue, 2019-06-18 at 21:46 -0400, Aaron Boxer wrote:
> Hello!
>
> I would like to receive an "on-app-rtcp" callback from the rtpsession
> when an APP packet is received by my RTSP client. From Wireshark, I
> see that the server sends a SR which includes an SDES and an APP
> block. Looking at the code, GStreamer treats the SDES and APP as
> report blocks, and it doesn't trigger the "on-app-rtcp" signal.  That
> signal is only triggered for a separate APP packet.
>
> I suppose one solution is to handle the raw RTCP packet callback, and
> parse APP myself, but would it be useful to add this handling to
> GStreamer report block code so we don't need to look at raw packet ?

Please create an issue for this :) Or even better an MR that implements
what you're suggesting. Intuitively I would've also expected the signal
to trigger whenever there's an APP RTCP packet, no matter in which
context it appears.

I use that signal in ristsrc and that worked nicely. So if there is an issue there, then it's rtsp specific.

--
Sebastian Dröge, Centricular Ltd · https://www.centricular.com

_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/gstreamer-devel

_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/gstreamer-devel