Re: [0.11] gstreamer: event: add sticky flags to events

[Stefan Sauer]

Am 02.05.2011 19:35, schrieb Wim Taymans:

> Module: gstreamer
> Branch: 0.11
> Commit: 2243adffa128c6f508b0926ee00bfb1b18fead5e
> URL:    http://cgit.freedesktop.org/gstreamer/gstreamer/commit/?id=2243adffa128c6f508b0926ee00bfb1b18fead5e
>
> Author: Wim Taymans <[hidden email]>
> Date:   Mon May  2 18:34:18 2011 +0200
>
> event: add sticky flags to events
>
> Add the sticky flag to events and a sticky index.
> Keep sticky events in an array on each pad.
> Remove GST_EVENT_SRC(), it is causing refcycles with sticky events, was not used
> and is not very interesting anyway.

What about using something like g_object_add_weak_pointer() - too heavy for
miniobjects?

Stefan

>
> ---
>
>  gst/gstevent.c |    9 +------
>  gst/gstevent.h |   67 +++++++++++++++++++++++++++++--------------------------
>  gst/gstinfo.c  |    6 +---
>  gst/gstpad.c   |   33 +++++++++++++++++++--------
>  gst/gstpad.h   |    1 +
>  5 files changed, 62 insertions(+), 54 deletions(-)
>
> Diff:   http://cgit.freedesktop.org/gstreamer/gstreamer/diff/?id=2243adffa128c6f508b0926ee00bfb1b18fead5e
> _______________________________________________
> gstreamer-commits mailing list
> [hidden email]
> http://lists.freedesktop.org/mailman/listinfo/gstreamer-commits

_______________________________________________
gstreamer-devel mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/gstreamer-devel

[José Alburquerque-3]

On Mon, 2011-05-02 at 23:15 +0300, Stefan Kost wrote:

> Am 02.05.2011 19:35, schrieb Wim Taymans:
> > Module: gstreamer
> > Branch: 0.11
> > Commit: 2243adffa128c6f508b0926ee00bfb1b18fead5e
> > URL:    http://cgit.freedesktop.org/gstreamer/gstreamer/commit/?id=2243adffa128c6f508b0926ee00bfb1b18fead5e
> >
> > Author: Wim Taymans <[hidden email]>
> > Date:   Mon May  2 18:34:18 2011 +0200
> >
> > event: add sticky flags to events
> >
> > Add the sticky flag to events and a sticky index.
> > Keep sticky events in an array on each pad.
> > Remove GST_EVENT_SRC(), it is causing refcycles with sticky events, was not used
> > and is not very interesting anyway.
>
> What about using something like g_object_add_weak_pointer() - too heavy for
> miniobjects?

There's a bug opened about adding a feature to ensure that data
associated with mini objects for bindings can be properly freed when the
mini objects are destroyed.  This would be another option to fix that
bug:

https://bugzilla.gnome.org/show_bug.cgi?id=609473

>
> Stefan
>
> >
> > ---
> >
> >  gst/gstevent.c |    9 +------
> >  gst/gstevent.h |   67 +++++++++++++++++++++++++++++--------------------------
> >  gst/gstinfo.c  |    6 +---
> >  gst/gstpad.c   |   33 +++++++++++++++++++--------
> >  gst/gstpad.h   |    1 +
> >  5 files changed, 62 insertions(+), 54 deletions(-)
> >
> > Diff:   http://cgit.freedesktop.org/gstreamer/gstreamer/diff/?id=2243adffa128c6f508b0926ee00bfb1b18fead5e
> > _______________________________________________
> > gstreamer-commits mailing list
> > [hidden email]
> > http://lists.freedesktop.org/mailman/listinfo/gstreamer-commits
>
> _______________________________________________
> gstreamer-devel mailing list
> [hidden email]
> http://lists.freedesktop.org/mailman/listinfo/gstreamer-devel

--
José

_______________________________________________
gstreamer-devel mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/gstreamer-devel