Re: [gst-cvs] dolphy gst-plugins-base: gst-plugins-base/ gst-plugins-base/ext/alsa/

[Jan Schmidt-6]

[hidden email] wrote:

> CVS Root:       /cvs/gstreamer
> Module:         gst-plugins-base
> Changes by:     dolphy
> Date:           Mon Feb 11 2008  17:03:32 UTC
>
> Log message:
> 2008-02-11  Julien Moutte  <[hidden email]>
>         Patch by: Alan Peevers <[hidden email]>
>         * ext/alsa/gstalsasink.c: (gst_alsasink_delay): Take appropriate
>         lock when calling alsa methods.
>  

Is there a bug report or a test case where this fixes a known issue?

If not, it's better not to take an extra lock in the clock get_time path
if we can avoid it.

J.

> Modified files:
>     .               : ChangeLog
>     ext/alsa        : gstalsasink.c
>
> Links:
> http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-base/ChangeLog.diff?r1=1.3739&r2=1.3740
> http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-base/ext/alsa/gstalsasink.c.diff?r1=1.87&r2=1.88
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2008.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> _______________________________________________
> gstreamer-cvs mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/gstreamer-cvs
>
>  

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gstreamer-devel

[Tim-Philipp Müller-2]

On Mon, 2008-02-11 at 20:04 +0000, Jan Schmidt wrote:

> [hidden email] wrote:
> > CVS Root:       /cvs/gstreamer
> > Module:         gst-plugins-base
> > Changes by:     dolphy
> > Date:           Mon Feb 11 2008  17:03:32 UTC
> >
> > Log message:
> > 2008-02-11  Julien Moutte  <[hidden email]>
> >         Patch by: Alan Peevers <[hidden email]>
> >         * ext/alsa/gstalsasink.c: (gst_alsasink_delay): Take appropriate
> >         lock when calling alsa methods.
> >  
> Is there a bug report or a test case where this fixes a known issue?
>
> If not, it's better not to take an extra lock in the clock get_time path
> if we can avoid it.

I've reverted this for now, since it breaks playback for me, and a short
discussion on IRC indicated that the patch in its current form might be
a bad idea.

 Cheers
  -Tim




-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gstreamer-devel