Re: [gst-cvs] ensonic gst-plugins-bad: gst-plugins-bad/ gst-plugins-bad/gst/rtpmanager/ gst-plugins-bad/sys/dshowsrcwrapper/

[Edward Hervey]

On Mon, 2008-08-11 at 00:20 -0700, [hidden email] wrote:

> CVS Root:       /cvs/gstreamer
> Module:         gst-plugins-bad
> Changes by:     ensonic
> Date:           Mon Aug 11 2008  07:20:29 UTC
>
> Log message:
> * gst/rtpmanager/gstrtpbin.c:
>  Print the pad-name in debug log.
> * sys/dshowsrcwrapper/gstdshowaudiosrc.c:
> * sys/dshowsrcwrapper/gstdshowvideosrc.c:
>  Use "-" instead of "_" in property names. Can we call them just
>  "device" like everywhere else?

  Isn't this considered 'API breakage' ? These elements have already
been in releases with those names. What happens for applications
expecting the older property naming ?

   Edward

>
> Modified files:
>     .               : ChangeLog
>     gst/rtpmanager  : gstrtpbin.c
>     sys/dshowsrcwrapper: gstdshowaudiosrc.c gstdshowvideosrc.c
>
> Links:
> http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-bad/ChangeLog.diff?r1=1.3487&r2=1.3488
> http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-bad/gst/rtpmanager/gstrtpbin.c.diff?r1=1.53&r2=1.54
> http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-bad/sys/dshowsrcwrapper/gstdshowaudiosrc.c.diff?r1=1.4&r2=1.5
> http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-bad/sys/dshowsrcwrapper/gstdshowvideosrc.c.diff?r1=1.5&r2=1.6
>
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> Build the coolest Linux based applications with Moblin SDK & win great prizes
> Grand prize is a trip for two to an Open Source event anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> _______________________________________________
> gstreamer-cvs mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/gstreamer-cvs

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gstreamer-devel

[Benoit Fouet]

Hi,

Edward Hervey wrote:

> On Mon, 2008-08-11 at 00:20 -0700, [hidden email] wrote:
>  
>> CVS Root:       /cvs/gstreamer
>> Module:         gst-plugins-bad
>> Changes by:     ensonic
>> Date:           Mon Aug 11 2008  07:20:29 UTC
>>
>> Log message:
>> * gst/rtpmanager/gstrtpbin.c:
>>  Print the pad-name in debug log.
>> * sys/dshowsrcwrapper/gstdshowaudiosrc.c:
>> * sys/dshowsrcwrapper/gstdshowvideosrc.c:
>>  Use "-" instead of "_" in property names. Can we call them just
>>  "device" like everywhere else?
>>    
>
>   Isn't this considered 'API breakage' ? These elements have already
> been in releases with those names. What happens for applications
> expecting the older property naming ?
>
>  

isn't there an implicit "equivalence" between foo_bar and foor-bar (and
foo bar IIRC) in property names anyway ?
(that will process a bit more, yes, but will still work)

--
Benoit Fouet
Purple Labs S.A.
www.purplelabs.com

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gstreamer-devel

[Sebastian Dröge]

Am Montag, den 11.08.2008, 12:59 +0200 schrieb Edward Hervey:

> On Mon, 2008-08-11 at 00:20 -0700, [hidden email] wrote:
> > CVS Root:       /cvs/gstreamer
> > Module:         gst-plugins-bad
> > Changes by:     ensonic
> > Date:           Mon Aug 11 2008  07:20:29 UTC
> >
> > Log message:
> > * gst/rtpmanager/gstrtpbin.c:
> >  Print the pad-name in debug log.
> > * sys/dshowsrcwrapper/gstdshowaudiosrc.c:
> > * sys/dshowsrcwrapper/gstdshowvideosrc.c:
> >  Use "-" instead of "_" in property names. Can we call them just
> >  "device" like everywhere else?
>
>   Isn't this considered 'API breakage' ? These elements have already
> been in releases with those names. What happens for applications
> expecting the older property naming ?

GObject will replace all "_" by "-" when installing the property anyway
so that's not changing any behaviour.

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gstreamer-devel

[Stefan Sauer]

Hi,

Edward Hervey schrieb:

> On Mon, 2008-08-11 at 00:20 -0700, [hidden email] wrote:
>> CVS Root:       /cvs/gstreamer
>> Module:         gst-plugins-bad
>> Changes by:     ensonic
>> Date:           Mon Aug 11 2008  07:20:29 UTC
>>
>> Log message:
>> * gst/rtpmanager/gstrtpbin.c:
>>  Print the pad-name in debug log.
>> * sys/dshowsrcwrapper/gstdshowaudiosrc.c:
>> * sys/dshowsrcwrapper/gstdshowvideosrc.c:
>>  Use "-" instead of "_" in property names. Can we call them just
>>  "device" like everywhere else?
>
>   Isn't this considered 'API breakage' ? These elements have already
> been in releases with those names. What happens for applications
> expecting the older property naming ?

Its not, gobject will convert if you use "_" and that we can skip. Its not
recommened to use "_" for properties and signals. Plus there was/is a bug that
connecting to notify::<prop-name> does not work when they use "_".

Stefan

>
>    Edward
>
>> Modified files:
>>     .               : ChangeLog
>>     gst/rtpmanager  : gstrtpbin.c
>>     sys/dshowsrcwrapper: gstdshowaudiosrc.c gstdshowvideosrc.c
>>
>> Links:
>> http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-bad/ChangeLog.diff?r1=1.3487&r2=1.3488
>> http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-bad/gst/rtpmanager/gstrtpbin.c.diff?r1=1.53&r2=1.54
>> http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-bad/sys/dshowsrcwrapper/gstdshowaudiosrc.c.diff?r1=1.4&r2=1.5
>> http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-bad/sys/dshowsrcwrapper/gstdshowvideosrc.c.diff?r1=1.5&r2=1.6
>>
>> -------------------------------------------------------------------------
>> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
>> Build the coolest Linux based applications with Moblin SDK & win great prizes
>> Grand prize is a trip for two to an Open Source event anywhere in the world
>> http://moblin-contest.org/redirect.php?banner_id=100&url=/
>> _______________________________________________
>> gstreamer-cvs mailing list
>> [hidden email]
>> https://lists.sourceforge.net/lists/listinfo/gstreamer-cvs
>
>
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> Build the coolest Linux based applications with Moblin SDK & win great prizes
> Grand prize is a trip for two to an Open Source event anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> _______________________________________________
> gstreamer-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/gstreamer-devel

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gstreamer-devel

[Jan Schmidt-6]

All of what everyone else said, plus: it's in gst-plugins-bad - changing
the interfaces is OK.

J.

On Mon, 2008-08-11 at 12:59 +0200, Edward Hervey wrote:

> On Mon, 2008-08-11 at 00:20 -0700, [hidden email] wrote:
> > CVS Root:       /cvs/gstreamer
> > Module:         gst-plugins-bad
> > Changes by:     ensonic
> > Date:           Mon Aug 11 2008  07:20:29 UTC
> >
> > Log message:
> > * gst/rtpmanager/gstrtpbin.c:
> >  Print the pad-name in debug log.
> > * sys/dshowsrcwrapper/gstdshowaudiosrc.c:
> > * sys/dshowsrcwrapper/gstdshowvideosrc.c:
> >  Use "-" instead of "_" in property names. Can we call them just
> >  "device" like everywhere else?
>
>   Isn't this considered 'API breakage' ? These elements have already
> been in releases with those names. What happens for applications
> expecting the older property naming ?
>
>    Edward
>
> >
> > Modified files:
> >     .               : ChangeLog
> >     gst/rtpmanager  : gstrtpbin.c
> >     sys/dshowsrcwrapper: gstdshowaudiosrc.c gstdshowvideosrc.c
> >
> > Links:
> > http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-bad/ChangeLog.diff?r1=1.3487&r2=1.3488
> > http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-bad/gst/rtpmanager/gstrtpbin.c.diff?r1=1.53&r2=1.54
> > http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-bad/sys/dshowsrcwrapper/gstdshowaudiosrc.c.diff?r1=1.4&r2=1.5
> > http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-bad/sys/dshowsrcwrapper/gstdshowvideosrc.c.diff?r1=1.5&r2=1.6
> >
> > -------------------------------------------------------------------------
> > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> > Build the coolest Linux based applications with Moblin SDK & win great prizes
> > Grand prize is a trip for two to an Open Source event anywhere in the world
> > http://moblin-contest.org/redirect.php?banner_id=100&url=/
> > _______________________________________________
> > gstreamer-cvs mailing list
> > [hidden email]
> > https://lists.sourceforge.net/lists/listinfo/gstreamer-cvs
>
>
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> Build the coolest Linux based applications with Moblin SDK & win great prizes
> Grand prize is a trip for two to an Open Source event anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> _______________________________________________
> gstreamer-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/gstreamer-devel
>

--
Jan Schmidt <[hidden email]>


-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gstreamer-devel