Re: [gst-cvs] ensonic gst-plugins-good: gst-plugins-good/ gst-plugins-good/gst/avi/

[Mark Nauwelaerts-2]

Though this changed code now probably also works in most cases, I believe there
is a danger.

The avi header is constructed (and written) twice; once a the start of the file,
and once at the end.  It is possible that the tag setter's list of tags has
changed in between which could make the second avi header larger than the first
time around, with corresponding effects.
The purpose of tags_snap was to make certain the avi header size was invariant
these two times around.  This has been removed here and seems not compensated in
  some other way.

Mark.

[hidden email] wrote:

> CVS Root:       /cvs/gstreamer
> Module:         gst-plugins-good
> Changes by:     ensonic
> Date:           Tue Dec 16 2008  11:57:15 UTC
>
> Log message:
> * gst/avi/gstavimux.c:
> * gst/avi/gstavimux.h:
>  Totally remove the internal taglists and fully use tagsetter.
>
> Modified files:
>     .               : ChangeLog
>     gst/avi         : gstavimux.c gstavimux.h
>
> Links:
> http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-good/ChangeLog.diff?r1=1.3865&r2=1.3866
> http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-good/gst/avi/gstavimux.c.diff?r1=1.110&r2=1.111
> http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-good/gst/avi/gstavimux.h.diff?r1=1.19&r2=1.20
>
> ------------------------------------------------------------------------------
> SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nevada.
> The future of the web can't happen without you.  Join us at MIX09 to help
> pave the way to the Next Web now. Learn more and register at
> http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/
> _______________________________________________
> gstreamer-cvs mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/gstreamer-cvs
>

------------------------------------------------------------------------------
SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nevada.
The future of the web can't happen without you.  Join us at MIX09 to help
pave the way to the Next Web now. Learn more and register at
http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gstreamer-devel

[Stefan Sauer]

hi,

Mark Nauwelaerts schrieb:

> Though this changed code now probably also works in most cases, I believe there
> is a danger.
>
> The avi header is constructed (and written) twice; once a the start of the file,
> and once at the end.  It is possible that the tag setter's list of tags has
> changed in between which could make the second avi header larger than the first
> time around, with corresponding effects.
> The purpose of tags_snap was to make certain the avi header size was invariant
> these two times around.  This has been removed here and seems not compensated in
>   some other way.

uhm, this was then not documented/commented at all. I am not sure how much I can
look at this between x-mas and new-year, but I'll definitely look at it before
next release. Thanks for pointing it out.

Stefan

>
> Mark.
>
> [hidden email] wrote:
>> CVS Root:       /cvs/gstreamer
>> Module:         gst-plugins-good
>> Changes by:     ensonic
>> Date:           Tue Dec 16 2008  11:57:15 UTC
>>
>> Log message:
>> * gst/avi/gstavimux.c:
>> * gst/avi/gstavimux.h:
>>  Totally remove the internal taglists and fully use tagsetter.
>>
>> Modified files:
>>     .               : ChangeLog
>>     gst/avi         : gstavimux.c gstavimux.h
>>
>> Links:
>> http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-good/ChangeLog.diff?r1=1.3865&r2=1.3866
>> http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-good/gst/avi/gstavimux.c.diff?r1=1.110&r2=1.111
>> http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-good/gst/avi/gstavimux.h.diff?r1=1.19&r2=1.20
>>
>> ------------------------------------------------------------------------------
>> SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nevada.
>> The future of the web can't happen without you.  Join us at MIX09 to help
>> pave the way to the Next Web now. Learn more and register at
>> http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/
>> _______________________________________________
>> gstreamer-cvs mailing list
>> [hidden email]
>> https://lists.sourceforge.net/lists/listinfo/gstreamer-cvs
>>
>
> ------------------------------------------------------------------------------
> SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nevada.
> The future of the web can't happen without you.  Join us at MIX09 to help
> pave the way to the Next Web now. Learn more and register at
> http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/
> _______________________________________________
> gstreamer-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/gstreamer-devel

------------------------------------------------------------------------------
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gstreamer-devel