GStreamer-devel

Re: [gst-cvs] ensonic gstreamer: gstreamer/ gstreamer/gst/

Classic

List

Threaded

4 messages Options

Jan Schmidt-2

Re: [gst-cvs] ensonic gstreamer: gstreamer/ gstreamer/gst/

<quote who="[hidden email]">

> CVS Root: /cvs/gstreamer
> Module: gstreamer
> Changes by: ensonic
> Date: Mon Mar 31 2008 08:32:40 UTC
>
> * gst/gstregistry.c:
> Only test plugin filenames against G_MODULE_SUFFIX.

This seems like a gratuitous change with screw-up potential - are you sure
there wasn't a good reason for testing the other extensions? On Mac OS/X
using macports, I know I see the plugins built as .so files and glibconfig.h
contains that as the G_MODULE_SUFFIX, but other shared-object files on the
system end up as .dylib, and I have no idea what the difference is or
whether we should be continuing to test that extension too.

Jan
--
Jan Schmidt [hidden email]

I came for the quality. I stayed for the freedom. -- Sean Neakums

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gstreamer-devel

Stefan Sauer

Re: [gst-cvs] ensonic gstreamer: gstreamer/ gstreamer/gst/

Hi,

Quoting Jan Schmidt <[hidden email]>:

> <quote who="[hidden email]">
>
>> CVS Root: /cvs/gstreamer
>> Module: gstreamer
>> Changes by: ensonic
>> Date: Mon Mar 31 2008 08:32:40 UTC
>>
>> * gst/gstregistry.c:
>> Only test plugin filenames against G_MODULE_SUFFIX.
>
> This seems like a gratuitous change with screw-up potential - are you sure
> there wasn't a good reason for testing the other extensions? On Mac OS/X
> using macports, I know I see the plugins built as .so files and glibconfig.h
> contains that as the G_MODULE_SUFFIX, but other shared-object files on the
> system end up as .dylib, and I have no idea what the difference is or
> whether we should be continuing to test that extension too.

Can someone with a mac verify? I can ofcourse revert it, but would
only like to do that if there is need and we can stick a fat comment
there why we dont use G_MODULE_SUFFIX 8as this seems to be a logical
thing to do).

To clarify, the issue you see is when running uninstalled, the plugins
won't be picked up, as their extension is .so (only turned into .dylib
when installing)?

Stefan

>
> Jan
> --
> Jan Schmidt [hidden email]
>
> I came for the quality. I stayed for the freedom. -- Sean Neakums
>
> -------------------------------------------------------------------------
> Check out the new SourceForge.net Marketplace.
> It's the best place to buy or sell services for
> just about anything Open Source.
> http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
> _______________________________________________
> gstreamer-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/gstreamer-devel
>

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gstreamer-devel

Edward Hervey

Re: [gst-cvs] ensonic gstreamer: gstreamer/ gstreamer/gst/

Administrator

In reply to this post by Jan Schmidt-2

Breaks behaviour on macosx, as Jan mentionned, please revert.

On Mon, 2008-03-31 at 01:28 -0700, [hidden email] wrote:

> CVS Root: /cvs/gstreamer
> Module: gstreamer
> Changes by: ensonic
> Date: Mon Mar 31 2008 08:32:40 UTC
>
> Log message:
> * gst/gst.c:
> Fix type in log message and add one to ease seeing how long registry
> cache verification takes.
> * gst/gstregistry.c:
> Only test plugin filenames against G_MODULE_SUFFIX.
>
> Modified files:
> . : ChangeLog
> gst : gst.c gstregistry.c
>
> Links:
> http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.3734&r2=1.3735
> http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gst.c.diff?r1=1.253&r2=1.254
> http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstregistry.c.diff?r1=1.75&r2=1.76
>
> -------------------------------------------------------------------------
> Check out the new SourceForge.net Marketplace.
> It's the best place to buy or sell services for
> just about anything Open Source.
> http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
> _______________________________________________
> gstreamer-cvs mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/gstreamer-cvs

Sebastian Dröge

Re: [gst-cvs] ensonic gstreamer: gstreamer/ gstreamer/gst/

On Mo, 2008-03-31 at 14:07 +0200, Edward Hervey wrote:
> Breaks behaviour on macosx, as Jan mentionned, please revert.

What about having OS specific hacks in there to still check only the
valid suffixes, i.e. .so and .dynlib for OS X, G_MODULE_SUFFIX for
everybody else?

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gstreamer-devel

signature.asc (196 bytes) Download Attachment