Re: [gst-cvs] ensonic gstreamer: gstreamer/ gstreamer/plugins/elements/

[Michael Smith-32]

On Wed, 2008-02-20 at 07:44 -0800, [hidden email] wrote:

> CVS Root:       /cvs/gstreamer
> Module:         gstreamer
> Changes by:     ensonic
> Date:           Wed Feb 20 2008  15:44:48 UTC
>
> Log message:
> * plugins/elements/gstqueue.c:
> * plugins/elements/gstqueue.h:
>  When dropping buffers in leaky modes, mark next buffers we sent as
>  DISCONT.

I didn't check this closely because I'm really busy right now, but this
looks like it's stomping on buffers without making them writable first.

Please be more careful!

Mike

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gstreamer-devel

[Stefan Sauer]

hi,
Quoting Michael Smith <[hidden email]>:

> On Wed, 2008-02-20 at 07:44 -0800, [hidden email] wrote:
>> CVS Root:       /cvs/gstreamer
>> Module:         gstreamer
>> Changes by:     ensonic
>> Date:           Wed Feb 20 2008  15:44:48 UTC
>>
>> Log message:
>> * plugins/elements/gstqueue.c:
>> * plugins/elements/gstqueue.h:
>>  When dropping buffers in leaky modes, mark next buffers we sent as
>>  DISCONT.
>
> I didn't check this closely because I'm really busy right now, but this
> looks like it's stomping on buffers without making them writable first.

thanks for the review. fixed in cvs.
>
> Please be more careful!
Please skip that in the future, okay?

Stefan

>
> Mike
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2008.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> _______________________________________________
> gstreamer-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/gstreamer-devel
>

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gstreamer-devel