Re: [gst-cvs] gst-openmax: .gitignore: ignore more

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: [gst-cvs] gst-openmax: .gitignore: ignore more

Edward Hervey
Administrator

> I'll interpret that as "I don't care", so I went ahead and made the
> modifications.

  ?? I would rather interpret the following as "I don't care about
GStreamer":

  * Removing usage of common submodule
  * Doing whitespace fixes after that and then suggesting those changes
go into common (you could have done it in common from the start)
  * Removing the gst-indent pre-commit
  * Not using the gstreamer indentation style (there's a REASON we use
it : it allows much faster reviewing of all gstreamer modules by other
GStreamer developers).

  Should we remove gst-openmax from git.freedesktop.org ?

    Edward

>
> Cheers.
>


------------------------------------------------------------------------------
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gstreamer-devel
Reply | Threaded
Open this post in threaded view
|

Re: [gst-cvs] gst-openmax: .gitignore: ignore more

Felipe Contreras
On Wed, Mar 25, 2009 at 12:20 PM, Edward Hervey <[hidden email]> wrote:
>
>> I'll interpret that as "I don't care", so I went ahead and made the
>> modifications.
>
>  ?? I would rather interpret the following as "I don't care about
> GStreamer":

What? From your response one would think that 'not caring' about
.gitignore was a bad thing. It's not, some people care, some people
don't. He doesn't, I do... there's nothing inherently wrong with that.

And now you throw a bunch of stuff that's completely unrelated:

>  * Removing usage of common submodule

So? What is the impact?

I'm thinking on adding a script that updates the files I copied from
'common' and firing it before making a release. How would that be any
different from the current situation?

>  * Doing whitespace fixes after that and then suggesting those changes
> go into common (you could have done it in common from the start)

I have suggested ways to improve 'common' and those were ignored.

I don't see why I should put high in my priority list whitespace
cleanups for something I don't think should even exist (common).

>  * Removing the gst-indent pre-commit

The only thing that script is doing is ensuring the current code has
two code-styles. Two code-styles = bad.

>  * Not using the gstreamer indentation style (there's a REASON we use
> it : it allows much faster reviewing of all gstreamer modules by other
> GStreamer developers).

There has been plenty of time to improve gst-openmax, including the
code-style, and I've never seen any interest in doing that on any
mailing list.

Now, the same day you proposed to update the code-style in our
internal (Nokia) IRC, I came up with a plan to do that without
disturbing anyone and I made it public on the gst-openmax mailing
list.

I'm executing that plan, and sent some patches for reviewing.

I'm also a busy person, and could spend my time doing some other more
productive stuff, and even though I'm doing exactly I said I would,
apparently that's not good enough for you.

>  Should we remove gst-openmax from git.freedesktop.org ?

Is that a threat? Well I'm going to seriously consider that as I
haven't seen any benefit from being on the 'GStreamer' umbrella at
all. If anything, it's the other way around, GStreamer has benefited
because in the embedded community vendors provide OpenMAX IL
components, not GStreamer.

--
Felipe Contreras

------------------------------------------------------------------------------
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gstreamer-devel
Reply | Threaded
Open this post in threaded view
|

Re: [gst-cvs] gst-openmax: .gitignore: ignore more

Zaheer Merali-2
On Wed, Mar 25, 2009 at 9:24 PM, Felipe Contreras
<[hidden email]> wrote:

> On Wed, Mar 25, 2009 at 12:20 PM, Edward Hervey <[hidden email]> wrote:
>>
>>> I'll interpret that as "I don't care", so I went ahead and made the
>>> modifications.
>>
>>  ?? I would rather interpret the following as "I don't care about
>> GStreamer":
>
> What? From your response one would think that 'not caring' about
> .gitignore was a bad thing. It's not, some people care, some people
> don't. He doesn't, I do... there's nothing inherently wrong with that.
>
> And now you throw a bunch of stuff that's completely unrelated:
>
>>  * Removing usage of common submodule
>
> So? What is the impact?
>
> I'm thinking on adding a script that updates the files I copied from
> 'common' and firing it before making a release. How would that be any
> different from the current situation?
>
>>  * Doing whitespace fixes after that and then suggesting those changes
>> go into common (you could have done it in common from the start)
>
> I have suggested ways to improve 'common' and those were ignored.
>
> I don't see why I should put high in my priority list whitespace
> cleanups for something I don't think should even exist (common).
>
>>  * Removing the gst-indent pre-commit
>
> The only thing that script is doing is ensuring the current code has
> two code-styles. Two code-styles = bad.
>
>>  * Not using the gstreamer indentation style (there's a REASON we use
>> it : it allows much faster reviewing of all gstreamer modules by other
>> GStreamer developers).
>
> There has been plenty of time to improve gst-openmax, including the
> code-style, and I've never seen any interest in doing that on any
> mailing list.
>
> Now, the same day you proposed to update the code-style in our
> internal (Nokia) IRC, I came up with a plan to do that without
> disturbing anyone and I made it public on the gst-openmax mailing
> list.
>
> I'm executing that plan, and sent some patches for reviewing.
>
> I'm also a busy person, and could spend my time doing some other more
> productive stuff, and even though I'm doing exactly I said I would,
> apparently that's not good enough for you.
>
>>  Should we remove gst-openmax from git.freedesktop.org ?
>
> Is that a threat? Well I'm going to seriously consider that as I
> haven't seen any benefit from being on the 'GStreamer' umbrella at
> all. If anything, it's the other way around, GStreamer has benefited
> because in the embedded community vendors provide OpenMAX IL
> components, not GStreamer.
>
> --
> Felipe Contreras
>

This all has blown out of proportion. Felipe, Tim and Edward should go
on irc and discuss the problems with gitignore, code style, common
etc. there and come up with a conclusion and learn to be able to talk
rationally between each other.

Zaheer

------------------------------------------------------------------------------
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gstreamer-devel
Reply | Threaded
Open this post in threaded view
|

Re: [gst-cvs] gst-openmax: .gitignore: ignore more

Tim-Philipp Müller-2
On Wed, 2009-03-25 at 23:48 +0100, Zaheer Merali wrote:

> This all has blown out of proportion. Felipe, Tim and Edward should go
> on irc and discuss the problems with gitignore, code style, common
> etc. there and come up with a conclusion and learn to be able to talk
> rationally between each other.

Err, please don't drag me into this, my only involvement in all this is
the original .gitignore commit, and I can really live with it being
reverted for whatever reason, as long as I don't have to engage in a
discussion to justify two lines in a .gitignore file.

I agree with you that this thread seems to have gone off the rails a bit
though. I'm sure solutions to whatever problems there may be can be
found by talking to each other on IRC as you suggest.

Cheers
 -Tim



------------------------------------------------------------------------------
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gstreamer-devel
Reply | Threaded
Open this post in threaded view
|

Re: [gst-cvs] gst-openmax: .gitignore: ignore more

Edward Hervey
Administrator
The issue has been dealt with privately.

  I apologize for the noise,

    Edward


------------------------------------------------------------------------------
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gstreamer-devel
Reply | Threaded
Open this post in threaded view
|

Re: [gst-cvs] gst-openmax: .gitignore: ignore more

Zaheer Merali-2
On Thu, Mar 26, 2009 at 7:09 AM, Edward Hervey <[hidden email]> wrote:
> The issue has been dealt with privately.
>
>  I apologize for the noise,
>
>    Edward
>
>

Thanks, that was all that I asked :)

------------------------------------------------------------------------------
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gstreamer-devel