Re: [gst-cvs] gst-plugins-base: audioconvert: fix typo in comment

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: [gst-cvs] gst-plugins-base: audioconvert: fix typo in comment

David Schleef-2
On Wed, May 05, 2010 at 10:29:12PM -0700, Stefan Kost wrote:

> Module: gst-plugins-base
> Branch: master
> Commit: 51739d562cb581a1c8ff9e80beb7aeab85d7f869
> URL:    http://cgit.freedesktop.org/gstreamer/gst-plugins-base/commit/?id=51739d562cb581a1c8ff9e80beb7aeab85d7f869
>
> Author: Stefan Kost <[hidden email]>
> Date:   Thu May  6 08:16:45 2010 +0300
>
> audioconvert: fix typo in comment
>
> ---
>
>  gst/audioconvert/audioconvert.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/gst/audioconvert/audioconvert.c b/gst/audioconvert/audioconvert.c
> index 4780324..580cb05 100644
> --- a/gst/audioconvert/audioconvert.c
> +++ b/gst/audioconvert/audioconvert.c
> @@ -427,7 +427,7 @@ audio_convert_prepare_context (AudioConvertCtx * ctx, AudioConvertFmt * in,
>    ctx->in = *in;
>    ctx->out = *out;
>  
> -  /* Don't dither or apply noise shaping if out depth is bigger than 20 bits
> +  /* Don't dither or apply noise shaping if our depth is bigger than 20 bits
>     * as DA converters only can do a SNR up to 20 bits in reality.
>     * Also don't dither or apply noise shaping if target depth is larger than
>     * source depth. */
>

I don't think this was a typo.  It was supposed to mean "output".



dave...


------------------------------------------------------------------------------

_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gstreamer-devel
Reply | Threaded
Open this post in threaded view
|

Re: [gst-cvs] gst-plugins-base: audioconvert: fix typo in comment

Stefan Sauer
Am 06.05.2010 23:56, schrieb David Schleef:

> On Wed, May 05, 2010 at 10:29:12PM -0700, Stefan Kost wrote:
>> Module: gst-plugins-base
>> Branch: master
>> Commit: 51739d562cb581a1c8ff9e80beb7aeab85d7f869
>> URL:    http://cgit.freedesktop.org/gstreamer/gst-plugins-base/commit/?id=51739d562cb581a1c8ff9e80beb7aeab85d7f869
>>
>> Author: Stefan Kost <[hidden email]>
>> Date:   Thu May  6 08:16:45 2010 +0300
>>
>> audioconvert: fix typo in comment
>>
>> ---
>>
>>  gst/audioconvert/audioconvert.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/gst/audioconvert/audioconvert.c b/gst/audioconvert/audioconvert.c
>> index 4780324..580cb05 100644
>> --- a/gst/audioconvert/audioconvert.c
>> +++ b/gst/audioconvert/audioconvert.c
>> @@ -427,7 +427,7 @@ audio_convert_prepare_context (AudioConvertCtx * ctx, AudioConvertFmt * in,
>>    ctx->in = *in;
>>    ctx->out = *out;
>>  
>> -  /* Don't dither or apply noise shaping if out depth is bigger than 20 bits
>> +  /* Don't dither or apply noise shaping if our depth is bigger than 20 bits
>>     * as DA converters only can do a SNR up to 20 bits in reality.
>>     * Also don't dither or apply noise shaping if target depth is larger than
>>     * source depth. */
>>
>
> I don't think this was a typo.  It was supposed to mean "output".

Then it should have probably said so :). Changed it to target depth like a bit
below.

Stefan

>
>
>
> dave...
>
>
> ------------------------------------------------------------------------------
>
> _______________________________________________
> gstreamer-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/gstreamer-devel


------------------------------------------------------------------------------

_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gstreamer-devel