Wouldn't a LANG=C in an appropriate place, like before $(SED),
fix this in a more intuitive way? //Peter > -----Original Message----- > From: Tim Mueller [mailto:[hidden email]] > Sent: den 18 november 2009 20:23 > To: [hidden email] > Subject: [gst-cvs] gstreamer: check: fix symbol exporting when building > under et_EE locale > > Module: gstreamer > Branch: master > Commit: 6b234d7ce4b687912e4778327945c64743db90ea > URL: > http://cgit.freedesktop.org/gstreamer/gstreamer/commit/?id=6b234d7ce4b6 > 87912e4778327945c64743db90ea > > Author: Priit Laes <[hidden email]> > Date: Mon Nov 16 15:47:57 2009 +0200 > > check: fix symbol exporting when building under et_EE locale > > [A-Z] regexp fails under et_EE locale because Z in Estonian alphabet is > located after S and therefore characters starting with 'TUV...' are not > in the range anymore. > > Fixes bug #602093. > > --- > > libs/gst/check/Makefile.am | 9 +++++---- > 1 files changed, 5 insertions(+), 4 deletions(-) > > diff --git a/libs/gst/check/Makefile.am b/libs/gst/check/Makefile.am > index 70b2f5f..724d6a6 100644 > --- a/libs/gst/check/Makefile.am > +++ b/libs/gst/check/Makefile.am > @@ -89,16 +89,17 @@ LIBGSTCHECK_EXPORTED_SYMBOLS = \ > $(LIBGSTCHECK_EXPORTED_VARS) \ > $(LIBGSTCHECK_EXPORTED_FUNCS) > > +# Please do not even think about changing the alphabet below into A- > Za-z. > +# It is there for purpose. (Bug #602093) > +CHECK_SYMS=`$(SED) -n -e 's/^..*CK_EXPORT[ ]\{1,\}\([_0- > 9ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz]\{1,\}\)..*$$/\1/ > p' @top_srcdir@/libs/gst/check/libcheck/check.h.in` > print-check-symbols: > - CHECK_SYMS=`$(SED) -n -e 's/^..*CK_EXPORT[ ]\{1,\}\([_0-9A-Za- > z]\{1,\}\)..*$$/\1/p' @top_srcdir@/libs/gst/check/libcheck/check.h.in` > ; \ > - for s in $$CHECK_SYMS; do \ > + for s in $(CHECK_SYMS); do \ > echo $$s; \ > done; > > $(SYMBOLS_FILE): > - CHECK_SYMS=`$(SED) -n -e 's/^..*CK_EXPORT[ ]\{1,\}\([_0-9A-Za- > z]\{1,\}\)..*$$/\1/p' @top_srcdir@/libs/gst/check/libcheck/check.h.in` > ; \ > rm -f $(SYMBOLS_FILE) 2>/dev/null; \ > - for s in $(LIBGSTCHECK_EXPORTED_SYMBOLS) $$CHECK_SYMS; do \ > + for s in $(LIBGSTCHECK_EXPORTED_SYMBOLS) $(CHECK_SYMS); do \ > echo $$s >> $(SYMBOLS_FILE); \ > done > > > > ----------------------------------------------------------------------- > ------- > Let Crystal Reports handle the reporting - Free Crystal Reports 2008 > 30-Day > trial. Simplify your report design, integration and deployment - and > focus on > what you do best, core application coding. Discover what's new with > Crystal Reports now. http://p.sf.net/sfu/bobj-july > _______________________________________________ > gstreamer-cvs mailing list > [hidden email] > https://lists.sourceforge.net/lists/listinfo/gstreamer-cvs ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ gstreamer-devel mailing list [hidden email] https://lists.sourceforge.net/lists/listinfo/gstreamer-devel |
On Thu, 2009-11-19 at 09:43 +0100, Peter Kjellerstedt wrote:
> Wouldn't a LANG=C in an appropriate place, like before $(SED), > fix this in a more intuitive way? It would have been a possibility. I did consider it, but didn't really find it more intuitive. De gustibus etc. Cheers -Tim ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ gstreamer-devel mailing list [hidden email] https://lists.sourceforge.net/lists/listinfo/gstreamer-devel |
Free forum by Nabble | Edit this page |