Re: [gst-cvs] gstreamer: registry: allow plugins to cache extra data in registry. Fixes #570233

[Tim-Philipp Müller-2]

On Sun, 2009-06-07 at 13:50 -0700, Stefan Kost wrote:

Hi,

> URL:    http://cgit.freedesktop.org/gstreamer/gstreamer/commit/?id=ed88db818b64982adcdcc29e88ad476358a0757d
> Author: Stefan Kost <[hidden email]>
> Date:   Sun Jun  7 23:46:54 2009 +0300
>
> registry: allow plugins to cache extra data in registry. Fixes #570233
>
> Add a GstStructure to GstPlugin. Plugins can retieve it in plugin_init and
> access the cached info or build the cache and store it there.

nice that you added this functionality, but:

 - may I ask if anyone reviewed this new API before you
   committed it? Putting a patch into bugzilla on a Saturday
   night and committing it on Sunday doesn't really cut it
   for non-trivial API. [*]

 - could you please add 'Since: 0.10.24' to the gtk-doc
   markup [*]

 - could you next time please clearly mention the API you
   added in your commit message, ideally including the
   'API' keyword [*], like:
   API: add gst_plugin_frobnicate_foo()

Thanks!

Cheers
 -Tim

[*] see http://gstreamer.freedesktop.org/wiki/GitDeveloperGuidelines



------------------------------------------------------------------------------
OpenSolaris 2009.06 is a cutting edge operating system for enterprises
looking to deploy the next generation of Solaris that includes the latest
innovations from Sun and the OpenSource community. Download a copy and
enjoy capabilities such as Networking, Storage and Virtualization.
Go to: http://p.sf.net/sfu/opensolaris-get
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gstreamer-devel

[Sebastian Dröge-7]

Am Montag, den 08.06.2009, 11:02 +0100 schrieb Tim-Philipp Müller:

> On Sun, 2009-06-07 at 13:50 -0700, Stefan Kost wrote:
>
> Hi,
>
> > URL:    http://cgit.freedesktop.org/gstreamer/gstreamer/commit/?id=ed88db818b64982adcdcc29e88ad476358a0757d
> > Author: Stefan Kost <[hidden email]>
> > Date:   Sun Jun  7 23:46:54 2009 +0300
> >
> > registry: allow plugins to cache extra data in registry. Fixes #570233
> >
> > Add a GstStructure to GstPlugin. Plugins can retieve it in plugin_init and
> > access the cached info or build the cache and store it there.
>
> nice that you added this functionality, but:
>
>  - may I ask if anyone reviewed this new API before you
>    committed it? Putting a patch into bugzilla on a Saturday
>    night and committing it on Sunday doesn't really cut it
>    for non-trivial API. [*]

I've reviewed the API and talked about it with Stefan on IRC yesterday.
Also the API is quite trivial IMHO, I mean it's just setting/getting a
GstStructure to a GstPlugin and writing/reading it to the registry ;)

------------------------------------------------------------------------------
OpenSolaris 2009.06 is a cutting edge operating system for enterprises
looking to deploy the next generation of Solaris that includes the latest
innovations from Sun and the OpenSource community. Download a copy and
enjoy capabilities such as Networking, Storage and Virtualization.
Go to: http://p.sf.net/sfu/opensolaris-get
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gstreamer-devel