Re: [gst-cvs] tpm gstreamer: gstreamer/ gstreamer/libs/gst/base/

[Stefan Sauer]

hi,

I wonder why we have g_warning() calls there. Do we want to use  
g_warning in adition to gst-debug logging for all error cases?

Stefan

Quoting [hidden email]:

> CVS Root:       /cvs/gstreamer
> Module:         gstreamer
> Changes by:     tpm
> Date:           Tue Jan 08 2008  21:14:12 UTC
>
> Log message:
> * libs/gst/base/gstbasetransform.c:
>  (gst_base_transform_transform_size):
>  Print element name with g_warning() if there's a problem
>  with the unit size.
>
> Modified files:
>     .               : ChangeLog
>     libs/gst/base   : gstbasetransform.c
>
> Links:
> http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.3613&r2=1.3614
> http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/libs/gst/base/gstbasetransform.c.diff?r1=1.104&r2=1.105
>
> -------------------------------------------------------------------------
> Check out the new SourceForge.net Marketplace.
> It's the best place to buy or sell services for
> just about anything Open Source.
> http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
> _______________________________________________
> gstreamer-cvs mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/gstreamer-cvs
>

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gstreamer-devel

[Tim-Philipp Müller-2]

On Wed, 2008-01-09 at 08:14 +0100, Stefan Kost wrote:

> I wonder why we have g_warning() calls there. Do we want to use  
> g_warning in addition to gst-debug logging for all error cases?

These errors are really programming errors, so the use of g_warning()
here is similar to how we use g_return_if_fail().

 Cheers
  -Tim



-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gstreamer-devel