Re: gstreamer: docs: add deprecation guards

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

Re: gstreamer: docs: add deprecation guards

Edward Hervey
Administrator
On Wed, 2011-05-18 at 00:17 -0700, Stefan Kost wrote:

> Module: gstreamer
> Branch: master
> Commit: 9ff4ec3104d2510b8f379ff38c671682ff795e33
> URL:    http://cgit.freedesktop.org/gstreamer/gstreamer/commit/?id=9ff4ec3104d2510b8f379ff38c671682ff795e33
>
> Author: Stefan Kost <[hidden email]>
> Date:   Mon May  2 15:36:14 2011 +0300
>
> docs: add deprecation guards
>
> Move GstPadIntLinkFunction to private header to avoid a dozen #ifdefs. Use a
> gpointer in public header instead.
>

  Did you mean to add it for the following ? It's unrelated to your
commit message, conflicts with the comment above it, and breaks the
build (make check).

   Edward

> ---
> diff --git a/gst/gstplugin.h b/gst/gstplugin.h
> index c4f9c44..3964cd2 100644
> --- a/gst/gstplugin.h
> +++ b/gst/gstplugin.h
> @@ -298,6 +298,7 @@ G_END_DECLS
>  /* We don't have deprecation guards here on purpose, it's enough to have
>   * deprecation guards around _gst_plugin_register_static(), and will result in
>   * much better error messages when compiling with -DGST_DISABLE_DEPRECATED */
> +#ifndef GST_DISABLE_DEPRECATED
>  #define GST_PLUGIN_DEFINE_STATIC(major,minor,name,description,init,version,license,package,origin)  \
>  static void GST_GNUC_CONSTRUCTOR \
>  _gst_plugin_static_init__ ##init (void) \
> @@ -318,6 +319,7 @@ _gst_plugin_static_init__ ##init (void) \
>    }; \
>    _gst_plugin_register_static (&plugin_desc_); \
>  }
> +#endif
>  
>  /**
>   * GST_LICENSE_UNKNOWN:
>
> _______________________________________________
> gstreamer-commits mailing list
> [hidden email]
> http://lists.freedesktop.org/mailman/listinfo/gstreamer-commits


_______________________________________________
gstreamer-devel mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/gstreamer-devel