Re: gstreamer: tests: add test to create a factory

[Sebastian Dröge-7]

On Tue, 2011-03-08 at 02:33 -0800, Stefan Kost wrote:
> Module: gstreamer
> Branch: master
> Commit: 7c98ae2b98c75d2eb27829e75a65aa8913e6777d
> URL:    http://cgit.freedesktop.org/gstreamer/gstreamer/commit/?id=7c98ae2b98c75d2eb27829e75a65aa8913e6777d
>
> Author: Stefan Kost <[hidden email]>
> Date:   Tue Mar  8 11:55:29 2011 +0200
>
> tests: add test to create a factory

What exactly is the reason for this test? Wouldn't it be better to
create a small GstElement subclass with pad templates and everything,
register it and check the created element factory?

Your test here is manually filling an element factory, which will always
succeed unless GLib/GObject is broken ;)

_______________________________________________
gstreamer-devel mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/gstreamer-devel

[Stefan Sauer]

On 08.03.2011 12:43, Sebastian Dröge wrote:

> On Tue, 2011-03-08 at 02:33 -0800, Stefan Kost wrote:
>> Module: gstreamer
>> Branch: master
>> Commit: 7c98ae2b98c75d2eb27829e75a65aa8913e6777d
>> URL:    http://cgit.freedesktop.org/gstreamer/gstreamer/commit/?id=7c98ae2b98c75d2eb27829e75a65aa8913e6777d
>>
>> Author: Stefan Kost <[hidden email]>
>> Date:   Tue Mar  8 11:55:29 2011 +0200
>>
>> tests: add test to create a factory
> What exactly is the reason for this test? Wouldn't it be better to
> create a small GstElement subclass with pad templates and everything,
> register it and check the created element factory?

https://bugzilla.gnome.org/show_bug.cgi?id=402141

> Your test here is manually filling an element factory, which will always
> succeed unless GLib/GObject is broken ;)

Yes, but initialy I was doing this wrong and got valgrind issues. But I
agree that now it is not meaning full (only helps to see that we don't
leak things) - I can remove the one check when adding the other tests in
the bug.

Stefan
>
>
> _______________________________________________
> gstreamer-devel mailing list
> [hidden email]
> http://lists.freedesktop.org/mailman/listinfo/gstreamer-devel

_______________________________________________
gstreamer-devel mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/gstreamer-devel