Small fix to VideoMixer

[Michael Rubinstein]

Hi All,

I found a problem that affects VideoMixer when building for Windows.

I found it in 0.10.30, but the problem is also in later versions.

In the file:

gst-plugins-good/gst/videomixer/blend.c

Please change line 101 from:

#if G_BYTE_ORDER == LITTLE_ENDIAN

To

#if G_BYTE_ORDER == G_LITTLE_ENDIAN


" LITTLE_ENDIAN" without the "G_" in not defined,  so the test comes out
wrong.

Thanks,
Michael Rubinstein

_______________________________________________
gstreamer-devel mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/gstreamer-devel

[Tim-Philipp Müller-2]

On Fri, 2012-08-24 at 13:38 -0400, Michael Rubinstein wrote:

> " LITTLE_ENDIAN" without the "G_" in not defined,  so the test comes
> out wrong.

Thanks, I've pushed your fix now. It would be great if next time you
could file a bug in bugzilla [0] instead to make sure the problem or
patch isn't overlooked or forgotten about.

 Cheers
  -Tim

[0] http://gstreamer.freedesktop.org/bugs/


_______________________________________________
gstreamer-devel mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/gstreamer-devel

[Michael Rubinstein]

> Date: Fri, 24 Aug 2012 19:47:09 +0100
> From: Tim-Philipp M?ller <[hidden email]>
>
> On Fri, 2012-08-24 at 13:38 -0400, Michael Rubinstein wrote:
>
> > " LITTLE_ENDIAN" without the "G_" in not defined,  so the test comes
> > out wrong.
>
> Thanks, I've pushed your fix now. It would be great if next time you could
file
> a bug in bugzilla [0] instead to make sure the problem or patch isn't
> overlooked or forgotten about.
>
>  Cheers
>   -Tim

I'll use bugzilla next time.  Thanks for accepting the fix.

Michael

_______________________________________________
gstreamer-devel mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/gstreamer-devel