gdiscreencapsrc crashes after 3 minutes if cursor=true

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

gdiscreencapsrc crashes after 3 minutes if cursor=true

Francis Rammeloo
It can be reproduced with this command:

gst-launch-0.10 gdiscreencapsrc cursor=true ! ffmpegcolorspace ! dshowvideosink

After about three minutes the video widget will be frozen and crashes
when closing it. This bug only occurs if cursor=true is set.

Do you want me to file a bug for this?

Grts,
Francis

------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gstreamer-devel
Reply | Threaded
Open this post in threaded view
|

Re: gdiscreencapsrc crashes after 3 minutes if cursor=true

Francis Rammeloo
2010/2/24 Francis Rammeloo <[hidden email]>:

> Do you want me to file a bug for this?
>

Actually I found the problem. The HBITMAP objects associated with the
cursor icon where not deleted causing a rapid increase in number of
used GDI objects.

This patch fixes the problem:

Index: Main/GStreamer/Source/gst-plugins-bad/sys/winscreencap/gstgdiscreencapsrc.c
===================================================================
--- Main/GStreamer/Source/gst-plugins-bad/sys/winscreencap/gstgdiscreencapsrc.c (revision
442)
+++ Main/GStreamer/Source/gst-plugins-bad/sys/winscreencap/gstgdiscreencapsrc.c (working
copy)
@@ -552,6 +552,9 @@
           ci.ptScreenPos.x - src->src_rect.left - ii.xHotspot,
           ci.ptScreenPos.y - src->src_rect.top - ii.yHotspot, ci.hCursor, 0, 0,
           0, NULL, DI_DEFAULTSIZE | DI_NORMAL | DI_COMPAT);
+
+      DeleteObject (ii.hbmColor);
+      DeleteObject (ii.hbmMask);
     }
   }

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gstreamer-devel
Reply | Threaded
Open this post in threaded view
|

Re: gdiscreencapsrc crashes after 3 minutes if cursor=true

Tim-Philipp Müller-2
On Wed, 2010-02-24 at 17:37 +0100, Francis Rammeloo wrote:

> 2010/2/24 Francis Rammeloo <[hidden email]>:
>
> > Do you want me to file a bug for this?
> >
>
> Actually I found the problem. The HBITMAP objects associated with the
> cursor icon where not deleted causing a rapid increase in number of
> used GDI objects.
>
> This patch fixes the problem:

Filed this as https://bugzilla.gnome.org/show_bug.cgi?id=611428

Cheers
 -Tim



------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gstreamer-devel