git email hook

[Felipe Contreras]

Hi,

It looks like I'm not the only one that thinks the example git email
hook sucks so I asked around there seems to be a much better
alternative:

git-notify:
http://source.winehq.org/git/tools.git/?a=blob;f=git-notify;hb=HEAD

--
Felipe Contreras

------------------------------------------------------------------------------
Create and Deploy Rich Internet Apps outside the browser with Adobe(R)AIR(TM)
software. With Adobe AIR, Ajax developers can use existing skills and code to
build responsive, highly engaging applications that combine the power of local
resources and data with the reach of the web. Download the Adobe AIR SDK and
Ajax docs to start building applications today-http://p.sf.net/sfu/adobe-com
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gstreamer-devel

[Felipe Contreras]

On Tue, Feb 3, 2009 at 2:50 PM, Felipe Contreras
<[hidden email]> wrote:
> Hi,
>
> It looks like I'm not the only one that thinks the example git email
> hook sucks so I asked around there seems to be a much better
> alternative:
>
> git-notify:
> http://source.winehq.org/git/tools.git/?a=blob;f=git-notify;hb=HEAD

I've looked into this and modified the script so it works with cgit
and it seems to work fine.

If for some reason a push contains too many commits instead of sending
hundreds of e-mails it can send one big e-mail with a short
description of all the commits. The limit of number e-mails to send
separately can be configured.

Also, it includes the diff by default, and if the diff is too big then
it puts the diff url instead. The size of the diff is configurable
too.

I'm attaching my modified script and I'll send an example e-mail soon.

--
Felipe Contreras

------------------------------------------------------------------------------
Create and Deploy Rich Internet Apps outside the browser with Adobe(R)AIR(TM)
software. With Adobe AIR, Ajax developers can use existing skills and code to
build responsive, highly engaging applications that combine the power of local
resources and data with the reach of the web. Download the Adobe AIR SDK and
Ajax docs to start building applications today-http://p.sf.net/sfu/adobe-com
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gstreamer-devel

[Felipe Contreras]

Module: gst-openmax
Branch: master
Commit: 10c238e8a34c4693a742f596faec4efe2185ea77
URL:    http://cgit.freedesktop.org/gstreamer/gst-openmax/commit/?id=10c238e8a34c4693a742f596faec4efe2185ea77

Author: Felipe Contreras <[hidden email]>
Date:   Wed Dec 10 18:58:03 2008 +0200

util: Fix for allocate buffer.

The buffer shall be freed only when allocated by us as opposed to some
other element.

Signed-off-by: Felipe Contreras <[hidden email]>

---

 omx/gstomx_util.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/omx/gstomx_util.c b/omx/gstomx_util.c
index 429d47a..1b34b9b 100644
--- a/omx/gstomx_util.c
+++ b/omx/gstomx_util.c
@@ -505,10 +505,11 @@ port_free_buffers (GOmxPort *port)
 
         if (omx_buffer)
         {
-#ifdef USE_ALLOCATE_BUFFER
+#if 0
+            /** @todo how shall we free that buffer? */
             g_free (omx_buffer->pBuffer);
             omx_buffer->pBuffer = NULL;
-#endif /* USE_ALLOCATE_BUFFER */
+#endif
 
             OMX_FreeBuffer (port->core->omx_handle, port->port_index, omx_buffer);
             port->buffers[i] = NULL;



------------------------------------------------------------------------------
Create and Deploy Rich Internet Apps outside the browser with Adobe(R)AIR(TM)
software. With Adobe AIR, Ajax developers can use existing skills and code to
build responsive, highly engaging applications that combine the power of local
resources and data with the reach of the web. Download the Adobe AIR SDK and
Ajax docs to start building applications today-http://p.sf.net/sfu/adobe-com
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gstreamer-devel

[Jan Schmidt-6]

I like it. I'd prefer to see multiple commits-in-one-push bundled
together like we have had them - it encourages smaller, more atomic
commits. I'd prefer the "If for some reason a push contains too many
commits instead of sending
hundreds of e-mails it can send one big e-mail with a short
description of all the commits." one big e-mail option, with the
threshold set pretty low.

Jan.

On Wed, 2009-02-04 at 23:08 +0200, [hidden email] wrote:

> Module: gst-openmax
> Branch: master
> Commit: 10c238e8a34c4693a742f596faec4efe2185ea77
> URL:    http://cgit.freedesktop.org/gstreamer/gst-openmax/commit/?id=10c238e8a34c4693a742f596faec4efe2185ea77
>
> Author: Felipe Contreras <[hidden email]>
> Date:   Wed Dec 10 18:58:03 2008 +0200
>
> util: Fix for allocate buffer.
>
> The buffer shall be freed only when allocated by us as opposed to some
> other element.
>
> Signed-off-by: Felipe Contreras <[hidden email]>
>
> ---
>
>  omx/gstomx_util.c |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/omx/gstomx_util.c b/omx/gstomx_util.c
> index 429d47a..1b34b9b 100644
> --- a/omx/gstomx_util.c
> +++ b/omx/gstomx_util.c
> @@ -505,10 +505,11 @@ port_free_buffers (GOmxPort *port)
>  
>          if (omx_buffer)
>          {
> -#ifdef USE_ALLOCATE_BUFFER
> +#if 0
> +            /** @todo how shall we free that buffer? */
>              g_free (omx_buffer->pBuffer);
>              omx_buffer->pBuffer = NULL;
> -#endif /* USE_ALLOCATE_BUFFER */
> +#endif
>  
>              OMX_FreeBuffer (port->core->omx_handle, port->port_index, omx_buffer);
>              port->buffers[i] = NULL;
>
>
>
> ------------------------------------------------------------------------------
> Create and Deploy Rich Internet Apps outside the browser with Adobe(R)AIR(TM)
> software. With Adobe AIR, Ajax developers can use existing skills and code to
> build responsive, highly engaging applications that combine the power of local
> resources and data with the reach of the web. Download the Adobe AIR SDK and
> Ajax docs to start building applications today-http://p.sf.net/sfu/adobe-com
> _______________________________________________
> gstreamer-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/gstreamer-devel
>

--
Jan Schmidt <[hidden email]>


------------------------------------------------------------------------------
Create and Deploy Rich Internet Apps outside the browser with Adobe(R)AIR(TM)
software. With Adobe AIR, Ajax developers can use existing skills and code to
build responsive, highly engaging applications that combine the power of local
resources and data with the reach of the web. Download the Adobe AIR SDK and
Ajax docs to start building applications today-http://p.sf.net/sfu/adobe-com
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gstreamer-devel

[Felipe Contreras]

On Wed, Feb 4, 2009 at 11:22 PM, Jan Schmidt <[hidden email]> wrote:
> I like it. I'd prefer to see multiple commits-in-one-push bundled
> together like we have had them - it encourages smaller, more atomic
> commits. I'd prefer the "If for some reason a push contains too many
> commits instead of sending
> hundreds of e-mails it can send one big e-mail with a short
> description of all the commits." one big e-mail option, with the
> threshold set pretty low.

Maybe, I would prefer separate e-mails because it's faster to process
them (I wouldn't even need to open the email to know what it is
about), and when I do open the mail chances are it already contains
all the information I would like to see. Right now that's not possible
because the subject of the emails don't even contain the first line of
the commit message.

My recommendation is to leave separate e-mails on, at least for a
while, and then decide.

--
Felipe Contreras

------------------------------------------------------------------------------
Create and Deploy Rich Internet Apps outside the browser with Adobe(R)AIR(TM)
software. With Adobe AIR, Ajax developers can use existing skills and code to
build responsive, highly engaging applications that combine the power of local
resources and data with the reach of the web. Download the Adobe AIR SDK and
Ajax docs to start building applications today-http://p.sf.net/sfu/adobe-com
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gstreamer-devel

[Felipe Contreras]

On Wed, Feb 4, 2009 at 11:22 PM, Jan Schmidt <[hidden email]> wrote:
> I like it. I'd prefer to see multiple commits-in-one-push bundled
> together like we have had them - it encourages smaller, more atomic
> commits. I'd prefer the "If for some reason a push contains too many
> commits instead of sending
> hundreds of e-mails it can send one big e-mail with a short
> description of all the commits." one big e-mail option, with the
> threshold set pretty low.

I'm attaching a new script with a small change; add the module at the
beginning of the subject.

--
Felipe Contreras

------------------------------------------------------------------------------
Create and Deploy Rich Internet Apps outside the browser with Adobe(R)AIR(TM)
software. With Adobe AIR, Ajax developers can use existing skills and code to
build responsive, highly engaging applications that combine the power of local
resources and data with the reach of the web. Download the Adobe AIR SDK and
Ajax docs to start building applications today-http://p.sf.net/sfu/adobe-com
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gstreamer-devel