[glimagesink] Adding new property to glimagesink and access it in wayland platform

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[glimagesink] Adding new property to glimagesink and access it in wayland platform

Vikas Patil
Hi All,

I would like to add new plug-in property (i.e. surface-id ) to glimagesink [1]. I have added required code to [1] as after looking at other properties. However I need this property value
to libgstsl.so [2].

Could anyone guide me how to get new property value from [1] libgstopengl.so to [2] libgstgl.so?


[1] https://cgit.freedesktop.org/gstreamer/gst-plugins-bad/tree/ext/gl/gstglimagesink.c?id=1.6.0
[2] https://cgit.freedesktop.org/gstreamer/gst-plugins-bad/tree/gst-libs/gst/gl/wayland/gstglwindow_wayland_egl.c?id=1.6.0

Thanking you.

Thanks & regards,
Vikash

_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/gstreamer-devel
Reply | Threaded
Open this post in threaded view
|

Re: [glimagesink] Adding new property to glimagesink and access it in wayland platform

Matthew Waters
Is this surface-id something what would be better suited for the
GstVideoOverlay interface that glimagesink and glwindow_wayland already
implement?

Cheers
-Matt


On 30/03/17 16:42, Vikas Patil wrote:

> Hi All,
>
> I would like to add new plug-in property (i.e. surface-id ) to
> glimagesink [1]. I have added required code to [1] as after looking at
> other properties. However I need this property value
> to libgstsl.so [2].
>
> Could anyone guide me how to get new property value from [1]
> libgstopengl.so to [2] libgstgl.so?
>
>
> [1]
> https://cgit.freedesktop.org/gstreamer/gst-plugins-bad/tree/ext/gl/gstglimagesink.c?id=1.6.0
> [2]
> https://cgit.freedesktop.org/gstreamer/gst-plugins-bad/tree/gst-libs/gst/gl/wayland/gstglwindow_wayland_egl.c?id=1.6.0
>
> Thanking you.
>
> Thanks & regards,
> Vikash


_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/gstreamer-devel

signature.asc (527 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [glimagesink] Adding new property to glimagesink and access it in wayland platform

Vikas Patil
Hi Matthew,

This surface-id is for wayland-ivi-extension (in-vehicle infotainment layer manager) support in glimagesink. I find GstGlWindow is not proper element and it seems it is internally invoked by glimagesink. I am working with Wayland platform.

Thanks & Regards,
Vikash

On Mar 31, 2017 4:02 AM, "Matthew Waters" <[hidden email]> wrote:
Is this surface-id something what would be better suited for the
GstVideoOverlay interface that glimagesink and glwindow_wayland already
implement?

Cheers
-Matt


On 30/03/17 16:42, Vikas Patil wrote:
> Hi All,
>
> I would like to add new plug-in property (i.e. surface-id ) to
> glimagesink [1]. I have added required code to [1] as after looking at
> other properties. However I need this property value
> to libgstsl.so [2].
>
> Could anyone guide me how to get new property value from [1]
> libgstopengl.so to [2] libgstgl.so?
>
>
> [1]
> https://cgit.freedesktop.org/gstreamer/gst-plugins-bad/tree/ext/gl/gstglimagesink.c?id=1.6.0
> [2]
> https://cgit.freedesktop.org/gstreamer/gst-plugins-bad/tree/gst-libs/gst/gl/wayland/gstglwindow_wayland_egl.c?id=1.6.0
>
> Thanking you.
>
> Thanks & regards,
> Vikash



_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/gstreamer-devel
Reply | Threaded
Open this post in threaded view
|

Re: [glimagesink] Adding new property to glimagesink and access it in wayland platform

Nicolas Dufresne-5
Le vendredi 31 mars 2017 à 07:13 +0530, Vikas Patil a écrit :
> This surface-id is for wayland-ivi-extension (in-vehicle infotainment
> layer manager) support in glimagesink. I find GstGlWindow is not
> proper element and it seems it is internally invoked by glimagesink.
> I am working with Wayland platform.

Would it be possible to provide some rational to these, slightly empty,
statements. All display sink in GStreamer will display to a "Window"
which is just a holder for a native handle specific to the display
system in place. On X11 this is an XID, on Wayland this is a surface
handle, etc. I also don't see you point about glimagesink using a
GstGLWindow abstraction to display. Why should that mechanism be forked
for cars make no sense to me.

regards,
Nicolas
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/gstreamer-devel

signature.asc (188 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [glimagesink] Adding new property to glimagesink and access it in wayland platform

Vikas Patil
In reply to this post by Vikas Patil

Hi Nicolas

In in-vehicle infotainment, we use weston (wayland compositor) with ivi-controller (wayland-ivi-extension, layermanager) instead of desktop shell for handling and controlling widow surfaces from various application.

Now for video playback with weston on i.mx6 soc I found glimagesink is the way to use, but as we are not using the desktop-shell there is no way to show video surfaces on display without wrapping weston surface to ILM (IVI Layermanager) using the ivi-application protocol. So in the use case where we need to create two video pipeline with different surface id for ILM I wanted to have this property in glimagesink with wayland so it can be passed to ivi-application.

See https://at.projects.genivi.org/wiki/display/PROJ/Wayland+IVI+Extension+Design for more details on ivi-application protocol and IVI ILM.

Thanks & Regards,

Vikash

From: Nicolas Dufresne <[hidden email]>

To: Discussion of the development of and with GStreamer

                <[hidden email]>, Matthew Waters

                <[hidden email]>

Subject: Re: [glimagesink] Adding new property to glimagesink and

                access it in wayland platform

Message-ID: <[hidden email]>

Content-Type: text/plain; charset="utf-8"

 

Le vendredi 31 mars 2017 à 07:13 +0530, Vikas Patil a écrit :

> This surface-id is for wayland-ivi-extension (in-vehicle infotainment

> layer manager) support in glimagesink. I find GstGlWindow is not

> proper element and it seems it is internally invoked by glimagesink.

> I am working with Wayland platform.

 

Would it be possible to provide some rational to these, slightly empty,

statements. All display sink in GStreamer will display to a "Window"

which is just a holder for a native handle specific to the display

system in place. On X11 this is an XID, on Wayland this is a surface

handle, etc. I also don't see you point about glimagesink using a

GstGLWindow abstraction to display. Why should that mechanism be forked

for cars make no sense to me.

 

regards,

Nicolas


On Fri, Mar 31, 2017 at 7:13 AM, Vikas Patil <[hidden email]> wrote:
Hi Matthew,

This surface-id is for wayland-ivi-extension (in-vehicle infotainment layer manager) support in glimagesink. I find GstGlWindow is not proper element and it seems it is internally invoked by glimagesink. I am working with Wayland platform.

Thanks & Regards,
Vikash

On Mar 31, 2017 4:02 AM, "Matthew Waters" <[hidden email]> wrote:
Is this surface-id something what would be better suited for the
GstVideoOverlay interface that glimagesink and glwindow_wayland already
implement?

Cheers
-Matt


On 30/03/17 16:42, Vikas Patil wrote:
> Hi All,
>
> I would like to add new plug-in property (i.e. surface-id ) to
> glimagesink [1]. I have added required code to [1] as after looking at
> other properties. However I need this property value
> to libgstsl.so [2].
>
> Could anyone guide me how to get new property value from [1]
> libgstopengl.so to [2] libgstgl.so?
>
>
> [1]
> https://cgit.freedesktop.org/gstreamer/gst-plugins-bad/tree/ext/gl/gstglimagesink.c?id=1.6.0
> [2]
> https://cgit.freedesktop.org/gstreamer/gst-plugins-bad/tree/gst-libs/gst/gl/wayland/gstglwindow_wayland_egl.c?id=1.6.0
>
> Thanking you.
>
> Thanks & regards,
> Vikash




_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/gstreamer-devel
Reply | Threaded
Open this post in threaded view
|

Re: Re: [glimagesink] Adding new property to glimagesink and access it in wayland platform

Matthew Waters

Right, so if the current GstGLDisplay/GstGLWindow implementations for wayland don't work for your platform, you will need to create your own based on what you have available in the IVI space.  Adding a property for something that's exposed through other means (like GstVideoOverlay) is *not* the correct way to go about this.

Cheers
-Matt


On 03/04/17 15:38, Vikas Patil wrote:

Hi Nicolas

In in-vehicle infotainment, we use weston (wayland compositor) with ivi-controller (wayland-ivi-extension, layermanager) instead of desktop shell for handling and controlling widow surfaces from various application.

Now for video playback with weston on i.mx6 soc I found glimagesink is the way to use, but as we are not using the desktop-shell there is no way to show video surfaces on display without wrapping weston surface to ILM (IVI Layermanager) using the ivi-application protocol. So in the use case where we need to create two video pipeline with different surface id for ILM I wanted to have this property in glimagesink with wayland so it can be passed to ivi-application.

See https://at.projects.genivi.org/wiki/display/PROJ/Wayland+IVI+Extension+Design for more details on ivi-application protocol and IVI ILM.

Thanks & Regards,

Vikash

From: Nicolas Dufresne <[hidden email]>

To: Discussion of the development of and with GStreamer

                <[hidden email]>, Matthew Waters

                <[hidden email]>

Subject: Re: [glimagesink] Adding new property to glimagesink and

                access it in wayland platform

Message-ID: <[hidden email]>

Content-Type: text/plain; charset="utf-8"

 

Le vendredi 31 mars 2017 à 07:13 +0530, Vikas Patil a écrit :

> This surface-id is for wayland-ivi-extension (in-vehicle infotainment

> layer manager) support in glimagesink. I find GstGlWindow is not

> proper element and it seems it is internally invoked by glimagesink.

> I am working with Wayland platform.

 

Would it be possible to provide some rational to these, slightly empty,

statements. All display sink in GStreamer will display to a "Window"

which is just a holder for a native handle specific to the display

system in place. On X11 this is an XID, on Wayland this is a surface

handle, etc. I also don't see you point about glimagesink using a

GstGLWindow abstraction to display. Why should that mechanism be forked

for cars make no sense to me.

 

regards,

Nicolas


On Fri, Mar 31, 2017 at 7:13 AM, Vikas Patil <[hidden email]> wrote:
Hi Matthew,

This surface-id is for wayland-ivi-extension (in-vehicle infotainment layer manager) support in glimagesink. I find GstGlWindow is not proper element and it seems it is internally invoked by glimagesink. I am working with Wayland platform.

Thanks & Regards,
Vikash

On Mar 31, 2017 4:02 AM, "Matthew Waters" <[hidden email]> wrote:
Is this surface-id something what would be better suited for the
GstVideoOverlay interface that glimagesink and glwindow_wayland already
implement?

Cheers
-Matt


On 30/03/17 16:42, Vikas Patil wrote:
> Hi All,
>
> I would like to add new plug-in property (i.e. surface-id ) to
> glimagesink [1]. I have added required code to [1] as after looking at
> other properties. However I need this property value
> to libgstsl.so [2].
>
> Could anyone guide me how to get new property value from [1]
> libgstopengl.so to [2] libgstgl.so?
>
>
> [1]
> https://cgit.freedesktop.org/gstreamer/gst-plugins-bad/tree/ext/gl/gstglimagesink.c?id=1.6.0
> [2]
> https://cgit.freedesktop.org/gstreamer/gst-plugins-bad/tree/gst-libs/gst/gl/wayland/gstglwindow_wayland_egl.c?id=1.6.0
>
> Thanking you.
>
> Thanks & regards,
> Vikash





_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/gstreamer-devel

signature.asc (527 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Re: [glimagesink] Adding new property to glimagesink and access it in wayland platform

Vikas Patil
It works for me but it seems there is no way to add properties to glimagesink. I didn't get GstVideoOverlay reference here. Could you please explain if possible?

While I was able to add the properties with similar kind video sink. I.e. waylandsink, eglvivsink.

Regards & Thanks,
Vikash


On Apr 5, 2017 5:35 AM, "Matthew Waters" <[hidden email]> wrote:

Right, so if the current GstGLDisplay/GstGLWindow implementations for wayland don't work for your platform, you will need to create your own based on what you have available in the IVI space.  Adding a property for something that's exposed through other means (like GstVideoOverlay) is *not* the correct way to go about this.

Cheers
-Matt


On 03/04/17 15:38, Vikas Patil wrote:

Hi Nicolas

In in-vehicle infotainment, we use weston (wayland compositor) with ivi-controller (wayland-ivi-extension, layermanager) instead of desktop shell for handling and controlling widow surfaces from various application.

Now for video playback with weston on i.mx6 soc I found glimagesink is the way to use, but as we are not using the desktop-shell there is no way to show video surfaces on display without wrapping weston surface to ILM (IVI Layermanager) using the ivi-application protocol. So in the use case where we need to create two video pipeline with different surface id for ILM I wanted to have this property in glimagesink with wayland so it can be passed to ivi-application.

See https://at.projects.genivi.org/wiki/display/PROJ/Wayland+IVI+Extension+Design for more details on ivi-application protocol and IVI ILM.

Thanks & Regards,

Vikash

From: Nicolas Dufresne <[hidden email]>

To: Discussion of the development of and with GStreamer

                <[hidden email]>, Matthew Waters

                <[hidden email]>

Subject: Re: [glimagesink] Adding new property to glimagesink and

                access it in wayland platform

Message-ID: <[hidden email]>

Content-Type: text/plain; charset="utf-8"

 

Le vendredi 31 mars 2017 à 07:13 +0530, Vikas Patil a écrit :

> This surface-id is for wayland-ivi-extension (in-vehicle infotainment

> layer manager) support in glimagesink. I find GstGlWindow is not

> proper element and it seems it is internally invoked by glimagesink.

> I am working with Wayland platform.

 

Would it be possible to provide some rational to these, slightly empty,

statements. All display sink in GStreamer will display to a "Window"

which is just a holder for a native handle specific to the display

system in place. On X11 this is an XID, on Wayland this is a surface

handle, etc. I also don't see you point about glimagesink using a

GstGLWindow abstraction to display. Why should that mechanism be forked

for cars make no sense to me.

 

regards,

Nicolas


On Fri, Mar 31, 2017 at 7:13 AM, Vikas Patil <[hidden email]> wrote:
Hi Matthew,

This surface-id is for wayland-ivi-extension (in-vehicle infotainment layer manager) support in glimagesink. I find GstGlWindow is not proper element and it seems it is internally invoked by glimagesink. I am working with Wayland platform.

Thanks & Regards,
Vikash

On Mar 31, 2017 4:02 AM, "Matthew Waters" <[hidden email]> wrote:
Is this surface-id something what would be better suited for the
GstVideoOverlay interface that glimagesink and glwindow_wayland already
implement?

Cheers
-Matt


On 30/03/17 16:42, Vikas Patil wrote:
> Hi All,
>
> I would like to add new plug-in property (i.e. surface-id ) to
> glimagesink [1]. I have added required code to [1] as after looking at
> other properties. However I need this property value
> to libgstsl.so [2].
>
> Could anyone guide me how to get new property value from [1]
> libgstopengl.so to [2] libgstgl.so?
>
>
> [1]
> https://cgit.freedesktop.org/gstreamer/gst-plugins-bad/tree/ext/gl/gstglimagesink.c?id=1.6.0
> [2]
> https://cgit.freedesktop.org/gstreamer/gst-plugins-bad/tree/gst-libs/gst/gl/wayland/gstglwindow_wayland_egl.c?id=1.6.0
>
> Thanking you.
>
> Thanks & regards,
> Vikash






_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/gstreamer-devel