gst-plugins-base-0.10.32: bug in gst-plugins-base-0.10.32/ext/pango/gsttextoverlay.c?

[bcxa sz]

Hi Developers,

I found one potential bug in gst_text_overlay_text_chain() in
ext/pango/gsttextoverlay.c (as the mail title).

If looked at this piece of code,
  ...
  if (G_LIKELY (GST_BUFFER_TIMESTAMP_IS_VALID (buffer))) {

    ...
    in_seg = gst_segment_clip (&overlay->text_segment, GST_FORMAT_TIME,
        GST_BUFFER_TIMESTAMP (buffer), stop, &clip_start, &clip_stop);
  } else {
    in_seg = TRUE;
  }

if (in_seg) {
  ...
  }
  GST_OBJECT_UNLOCK (overlay); // NOTE the buffer will not be unref in
case of in_seg == FALSE

beach:

  return ret;
}

If the in_seg == TRUE, the text buffer will render the text and push
into the queue.

But if in_seg = FALSE, the text buffer will not be unrefed. So I think
this is the bug and should add code to handle unref the buffer in case
of in_seg == FALSE.

Let me know if I am wrong.

best regards

BCXA
_______________________________________________
gstreamer-devel mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/gstreamer-devel

[Tim-Philipp Müller-2]

On Fri, 2011-08-19 at 18:15 +0800, bcxa sz wrote:

Hi,

> I found one potential bug in gst_text_overlay_text_chain() in
> ext/pango/gsttextoverlay.c (as the mail title).

Please file bugs in bugzilla, so they don't get lost.

Also, maybe you could check if the bug still exists in the latest
releases (0.10.35) and in git.

Cheers
 -Tim


_______________________________________________
gstreamer-devel mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/gstreamer-devel