gst-plugins-base circular build problem

[Thomas Vander Stichele]

Hi,

gst-libs/gst/interfaces depends on built versions of .gir files in its
sibling directories.  However, Makefile.am in gst-libs/gst says
specifically that interfaces should be built before all other dirs
because of built headers.

Is this a circular build problem, and did whoever who added the .gir
stuff oversee this ? Or am I missing something here ?

Thomas

--
I were but little happy
If I could say how much.
--
GStreamer - bringing multimedia to your desktop
http://gstreamer.freedesktop.org/



------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gstreamer-devel

[Sebastian Dröge-7]

On Thu, 2010-03-18 at 01:30 +0100, Thomas Vander Stichele wrote:
> Hi,
>
> gst-libs/gst/interfaces depends on built versions of .gir files in its
> sibling directories.  However, Makefile.am in gst-libs/gst says
> specifically that interfaces should be built before all other dirs
> because of built headers.
>
> Is this a circular build problem, and did whoever who added the .gir
> stuff oversee this ? Or am I missing something here ?

Good catch but this problem is in the header files too: xoverlay.h
includes ../video/gstvideosink.h for no good reason it seems. I'll fix
this later.

------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gstreamer-devel

[Sebastian Dröge-7]

On Thu, 2010-03-18 at 10:11 +0100, Sebastian Dröge wrote:

> On Thu, 2010-03-18 at 01:30 +0100, Thomas Vander Stichele wrote:
> > Hi,
> >
> > gst-libs/gst/interfaces depends on built versions of .gir files in its
> > sibling directories.  However, Makefile.am in gst-libs/gst says
> > specifically that interfaces should be built before all other dirs
> > because of built headers.
> >
> > Is this a circular build problem, and did whoever who added the .gir
> > stuff oversee this ? Or am I missing something here ?
>
> Good catch but this problem is in the header files too: xoverlay.h
> includes ../video/gstvideosink.h for no good reason it seems. I'll fix
> this later.

"No good reason" was wrong. It's used for GstVideoRectangle. I guess we
should move that struct into the interfaces library and let the video
library use it from there...

------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gstreamer-devel

[Sebastian Dröge-7]

On Thu, 2010-03-18 at 10:17 +0100, Sebastian Dröge wrote:

> On Thu, 2010-03-18 at 10:11 +0100, Sebastian Dröge wrote:
> > On Thu, 2010-03-18 at 01:30 +0100, Thomas Vander Stichele wrote:
> > > Hi,
> > >
> > > gst-libs/gst/interfaces depends on built versions of .gir files in its
> > > sibling directories.  However, Makefile.am in gst-libs/gst says
> > > specifically that interfaces should be built before all other dirs
> > > because of built headers.
> > >
> > > Is this a circular build problem, and did whoever who added the .gir
> > > stuff oversee this ? Or am I missing something here ?
> >
> > Good catch but this problem is in the header files too: xoverlay.h
> > includes ../video/gstvideosink.h for no good reason it seems. I'll fix
> > this later.

For details see https://bugzilla.gnome.org/show_bug.cgi?id=610249

------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gstreamer-devel

[Stefan Sauer]

Sebastian Dröge wrote:

> On Thu, 2010-03-18 at 10:11 +0100, Sebastian Dröge wrote:
>  
>> On Thu, 2010-03-18 at 01:30 +0100, Thomas Vander Stichele wrote:
>>    
>>> Hi,
>>>
>>> gst-libs/gst/interfaces depends on built versions of .gir files in its
>>> sibling directories.  However, Makefile.am in gst-libs/gst says
>>> specifically that interfaces should be built before all other dirs
>>> because of built headers.
>>>
>>> Is this a circular build problem, and did whoever who added the .gir
>>> stuff oversee this ? Or am I missing something here ?
>>>      
>> Good catch but this problem is in the header files too: xoverlay.h
>> includes ../video/gstvideosink.h for no good reason it seems. I'll fix
>> this later.
>>    
>
> "No good reason" was wrong. It's used for GstVideoRectangle. I guess we
> should move that struct into the interfaces library and let the video
> library use it from there...
>  

Whats the problem with the include? Does this trigger any build rules
differently?

Stefan

------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gstreamer-devel

[Thomas Vander Stichele]

Hi Sebastien,

thanks for taking a look.


In addition to the previously mentioned problems, I also run into:

make[5]: Entering directory
`/home/thomas/gst/git/gst-plugins-base/gst-libs/gst/audio'
  GEN    GstAudio-0.10.gir
Traceback (most recent call last):
  File "/usr/bin/g-ir-scanner", line 38, in <module>
    sys.exit(scanner_main(sys.argv))
  File "/usr/lib/python2.6/site-packages/giscanner/scannermain.py", line
277, in scanner_main
    transformer.register_include(include_obj)
  File "/usr/lib/python2.6/site-packages/giscanner/transformer.py", line
112, in register_include
    self._parse_include(filename)
  File "/usr/lib/python2.6/site-packages/giscanner/transformer.py", line
140, in _parse_include
    self.register_include(include)
  File "/usr/lib/python2.6/site-packages/giscanner/transformer.py", line
111, in register_include
    filename = self._find_include(include)
  File "/usr/lib/python2.6/site-packages/giscanner/transformer.py", line
129, in _find_include
    % (girname, searchdirs))
ValueError: Couldn't find include 'GstVideo-0.10.gir' (search path:
['/home/thomas/gst/git/gstreamer/pkgconfig/../gst',
'/home/thomas/gst/git/gstreamer/pkgconfig/../libs/gst/base',
'./../interfaces', '/usr/share/gir-1.0', '/usr/share/gir-1.0',
'/usr/share/gir-1.0'])
make[5]: *** [GstAudio-0.10.gir] Error 1
make[5]: Leaving directory
`/home/thomas/gst/git/gst-plugins-base/gst-libs/gst/audio'
make[4]: *** [all] Error 2
make[4]: Leaving directory
`/home/thomas/gst/git/gst-plugins-base/gst-libs/gst/audio'
make[3]: *** [all-recursive] Error 1
make[3]: Leaving directory
`/home/thomas/gst/git/gst-plugins-base/gst-libs/gst'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory
`/home/thomas/gst/git/gst-plugins-base/gst-libs'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/thomas/gst/git/gst-plugins-base'
make: *** [all] Error 2

I've been patching it up locally to add the video dir to the gir
invocations, but I'm surprised that the audio stuff would need the video
gir files...

Since I don't know enough about gir, maybe I'll let you work on it first
and then try again and see if I can do any further work.

Thomas

--
all I want is happiness
happiness
if you find it share it
with the rest of us
--
Flumotion - the only way to stream!
http://www.flumotion.net/



------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gstreamer-devel