I just started to work on a GstControlSource subclass for my project, and as I
was referring to the source for GstInterpolateControlSource for guidance, I saw something in gstinterpolate.c that I'm trying to understand. Thought I'd pass it by this mailing list to check what's going on. The line number is 137: ret = _interpolate_none_get_##type (self, timestamp); \ This line is in the middle of a loop that fills in the values for the elements of the returned array. From what I've gathered, the returned array should contain a time series of values, but the value of "timestamp" appears not to change in the loop. OTOH, there's an unused variable "ts" in this function, which to me would be the proper value to use in place of "timestamp" in line 137. Am I mis-interpreting what gst_control_source_get_value_array is supposed to do, or is there a bug in the code? (Similar code appears in other functions within gstinterpolate.c, so I'm uncertain.) -- Martin ------------------------------------------------------------------------------ Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are powering Web 2.0 with engaging, cross-platform capabilities. Quickly and easily build your RIAs with Flex Builder, the Eclipse(TM)based development software that enables intelligent coding and step-through debugging. Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com _______________________________________________ gstreamer-devel mailing list [hidden email] https://lists.sourceforge.net/lists/listinfo/gstreamer-devel |
Martin Pokorny schrieb:
> I just started to work on a GstControlSource subclass for my project, and as I > was referring to the source for GstInterpolateControlSource for guidance, I saw > something in gstinterpolate.c that I'm trying to understand. Thought I'd pass it > by this mailing list to check what's going on. The line number is 137: > > ret = _interpolate_none_get_##type (self, timestamp); \ > > This line is in the middle of a loop that fills in the values for the elements > of the returned array. From what I've gathered, the returned array should > contain a time series of values, but the value of "timestamp" appears not to > change in the loop. OTOH, there's an unused variable "ts" in this function, > which to me would be the proper value to use in place of "timestamp" in line > 137. Am I mis-interpreting what gst_control_source_get_value_array is supposed > to do, or is there a bug in the code? (Similar code appears in other functions > within gstinterpolate.c, so I'm uncertain.) > Doh, you are totally right. Fixed in git HEAD. Stefan ------------------------------------------------------------------------------ Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are powering Web 2.0 with engaging, cross-platform capabilities. Quickly and easily build your RIAs with Flex Builder, the Eclipse(TM)based development software that enables intelligent coding and step-through debugging. Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com _______________________________________________ gstreamer-devel mailing list [hidden email] https://lists.sourceforge.net/lists/listinfo/gstreamer-devel |
Free forum by Nabble | Edit this page |