rfbsrc - support for shared desktop

[Ilja Pavkovic-2]

Hi there,

I wrote a patch to support shared desktops. Who can insert this change to cvs?

(I must admit that I did not test it yet, as my compile environment is not
setup correctly, I just wrote down the change :-))

Best Regards,
        Ilja Pavkovic

-------------------------------------------------------------------------
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gstreamer-devel

[Ilja Pavkovic-2]

Hi,


> I wrote a patch to support shared desktops. Who can insert this change to
> cvs?
additionally to my original patch I also initialize shared_flag accordingly.  
See attached file.

Best Regards,
  Ilja Pavkovic



-------------------------------------------------------------------------
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gstreamer-devel

[Benoit Fouet]

Hi,

Ilja Pavkovic wrote:

> Hi,
>> I wrote a patch to support shared desktops. Who can insert this change to
>> cvs?
>>    
> additionally to my original patch I also initialize shared_flag accordingly.  
> See attached file.
>  
> ------------------------------------------------------------------------
>
> diff -ruN gst-plugins-bad/gst/librfb.orig/gstrfbsrc.c gst-plugins-bad/gst/librfb/gstrfbsrc.c
> --- gst-plugins-bad/gst/librfb.orig/gstrfbsrc.c 2008-07-08 00:42:54.274796000 +0200
> +++ gst-plugins-bad/gst/librfb/gstrfbsrc.c 2008-07-08 10:21:34.323226828 +0200
> @@ -43,7 +43,8 @@
>    ARG_WIDTH,
>    ARG_HEIGHT,
>    ARG_INCREMENTAL,
> -  ARG_USE_COPYRECT
> +  ARG_USE_COPYRECT,
> +  ARG_SHARED
>  };
>  
>  GST_DEBUG_CATEGORY_STATIC (rfbsrc_debug);
> @@ -148,6 +149,9 @@
>    g_object_class_install_property (gobject_class, ARG_USE_COPYRECT,
>        g_param_spec_boolean ("use-copyrect", "Use copyrect encoding",
>            "Use copyrect encoding", FALSE, G_PARAM_READWRITE));
> +  g_object_class_install_property (gobject_class, ARG_SHARED,
> +      g_param_spec_boolean ("shared", "Share desktop with other clients",
> +          "Share desktop with other clients", TRUE, G_PARAM_READWRITE));
>  

you define it as read write...

>    gstbasesrc_class->start = GST_DEBUG_FUNCPTR (gst_rfb_src_start);
>    gstbasesrc_class->stop = GST_DEBUG_FUNCPTR (gst_rfb_src_stop);
>    gstbasesrc_class->event = GST_DEBUG_FUNCPTR (gst_rfb_src_event);
> @@ -273,6 +277,9 @@
>      case ARG_USE_COPYRECT:
>        src->decoder->use_copyrect = g_value_get_boolean (value);
>        break;
> +    case ARG_SHARED:
> +      src->decoder->shared_flag = g_value_get_boolean (value);
> +      break;
>      default:
>        break;
>  

... but you seem to lack the read part

--
Benoit Fouet
Purple Labs S.A.
www.purplelabs.com

-------------------------------------------------------------------------
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gstreamer-devel

[Ilja Pavkovic-2]

Hi,

I already have been in touch with Thjis Vermeir and he applied all my patches
to the cvs :)

Best Regards,
        Ilja Pavkovic

Am Donnerstag Juli 10 2008 11:16:22 schrieb Benoit Fouet:

> Hi,
>
> Ilja Pavkovic wrote:
> > Hi,
> >
> >> I wrote a patch to support shared desktops. Who can insert this change
> >> to cvs?
> >
> > additionally to my original patch I also initialize shared_flag
> > accordingly. See attached file.
> >
> > ------------------------------------------------------------------------
> >
> > diff -ruN gst-plugins-bad/gst/librfb.orig/gstrfbsrc.c
> > gst-plugins-bad/gst/librfb/gstrfbsrc.c ---
> > gst-plugins-bad/gst/librfb.orig/gstrfbsrc.c 2008-07-08 00:42:54.274796000
> > +0200 +++ gst-plugins-bad/gst/librfb/gstrfbsrc.c 2008-07-08
> > 10:21:34.323226828 +0200 @@ -43,7 +43,8 @@
> >    ARG_WIDTH,
> >    ARG_HEIGHT,
> >    ARG_INCREMENTAL,
> > -  ARG_USE_COPYRECT
> > +  ARG_USE_COPYRECT,
> > +  ARG_SHARED
> >  };
> >
> >  GST_DEBUG_CATEGORY_STATIC (rfbsrc_debug);
> > @@ -148,6 +149,9 @@
> >    g_object_class_install_property (gobject_class, ARG_USE_COPYRECT,
> >        g_param_spec_boolean ("use-copyrect", "Use copyrect encoding",
> >            "Use copyrect encoding", FALSE, G_PARAM_READWRITE));
> > +  g_object_class_install_property (gobject_class, ARG_SHARED,
> > +      g_param_spec_boolean ("shared", "Share desktop with other
> > clients", +          "Share desktop with other clients", TRUE,
> > G_PARAM_READWRITE));
>
> you define it as read write...
>
> >    gstbasesrc_class->start = GST_DEBUG_FUNCPTR (gst_rfb_src_start);
> >    gstbasesrc_class->stop = GST_DEBUG_FUNCPTR (gst_rfb_src_stop);
> >    gstbasesrc_class->event = GST_DEBUG_FUNCPTR (gst_rfb_src_event);
> > @@ -273,6 +277,9 @@
> >      case ARG_USE_COPYRECT:
> >        src->decoder->use_copyrect = g_value_get_boolean (value);
> >        break;
> > +    case ARG_SHARED:
> > +      src->decoder->shared_flag = g_value_get_boolean (value);
> > +      break;
> >      default:
> >        break;
>
> ... but you seem to lack the read part

-------------------------------------------------------------------------
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gstreamer-devel