rtspsrc crash after recent commit in 1.12

[jml5qh]

In commit, a722f6e8329032c6eda4865d6a07f4ba5981d7ea two mutex's were added in GstRTSPConnInfo. However, I am getting a crash when my initial connection fails with Unauthorized. In that scenario, gst_rtsp_conninfo_close is immediately called. In gst_rtsp_conninfo_close, we then try and clear the locks but at that point they haven't been initialized. Note that I'm building GStreamer myself using cerbero so I wanted to confirm that this is a possible issue.

[Sebastian Dröge-3]

On Tue, 2017-06-27 at 12:30 -0700, jml5qh wrote:
> In commit, a722f6e8329032c6eda4865d6a07f4ba5981d7ea two mutex's were added in
> GstRTSPConnInfo. However, I am getting a crash when my initial connection
> fails with Unauthorized. In that scenario, gst_rtsp_conninfo_close is
> immediately called. In gst_rtsp_conninfo_close, we then try and clear the
> locks but at that point they haven't been initialized. Note that I'm
> building GStreamer myself using cerbero so I wanted to confirm that this is
> a possible issue.

This will be a bug. Can you report it in Bugzilla, ideally with a
testcase to reproduce it or the exact course of events that leads to
it? It sounds like you already know enough about the problem to also
provide a patch :)

--
Sebastian Dröge, Centricular Ltd · http://www.centricular.com
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/gstreamer-devel

[jml5qh]

Thank you very much! I have created bug 784282 at https://bugzilla.gnome.org/show_bug.cgi?id=784282. I unfortunately don't really know anything about mutex's so I'm not sure what to check before we can call g_mutex_clear. Because of this, I haven't created a patch at this time.

[Nicolas Dufresne-5]

Le mercredi 28 juin 2017 à 05:26 -0700, jml5qh a écrit :
> Thank you very much! I have created bug 784282 at 
> https://bugzilla.gnome.org/show_bug.cgi?id=784282
> <https://bugzilla.gnome.org/show_bug.cgi?id=784282>  . I
> unfortunately don't
> really know anything about mutex's so I'm not sure what to check
> before we
> can call g_mutex_clear. Because of this, I haven't created a patch at
> this
> time.

There is nothing to check, we should just not create/destroy mutex upon
connect/disconnect.

Nicolas
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/gstreamer-devel