videocrop left or right yelds same result

[RiccardoCagnasso]

In short, this pipeline https://imgur.com/uZ8uCmf

yields to this result https://imgur.com/tZ6ur5S

It's like videocrop left and videocrop right both crop from the right.

Swapping videocrop for videobox yields the intended result (but the
framerate drops).



--
Sent from: http://gstreamer-devel.966125.n4.nabble.com/
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/gstreamer-devel

[Nicolas Dufresne-5]

Le mercredi 28 août 2019 à 09:16 -0500, RiccardoCagnasso a écrit :
> In short, this pipeline https://imgur.com/uZ8uCmf

Can you give this in text please, it's very annoying and slow to read
these images or pipeline.

>
> yields to this result https://imgur.com/tZ6ur5S

From the screenshot, I can see that you are using a wayland or gl over
wayland sink. The cropping offload is broken there. You can disable
offload with:

  ... ! videocrop ! identity drop-allocation=1 ! glimagesink

This will crop in software instead of offloading.

>
> It's like videocrop left and videocrop right both crop from the right.
>
> Swapping videocrop for videobox yields the intended result (but the
> framerate drops).
>
>
>
> --
> Sent from: http://gstreamer-devel.966125.n4.nabble.com/
> _______________________________________________
> gstreamer-devel mailing list
> [hidden email]
> https://lists.freedesktop.org/mailman/listinfo/gstreamer-devel

_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/gstreamer-devel

[RiccardoCagnasso]

>Can you give this in text please, it's very annoying and slow to read these
images or pipeline.

sure https://pastebin.com/SiNRSX2y

> From the screenshot, I can see that you are using a wayland or gl over
> wayland sink.

Actually I'm using xvimagesink over Xorg




--
Sent from: http://gstreamer-devel.966125.n4.nabble.com/
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/gstreamer-devel

[Nicolas Dufresne-5]

Le mercredi 28 août 2019 à 11:11 -0500, RiccardoCagnasso a écrit :
> > Can you give this in text please, it's very annoying and slow to read these
> images or pipeline.
>
> sure https://pastebin.com/SiNRSX2y
>
> > From the screenshot, I can see that you are using a wayland or gl over
> > wayland sink.
>
> Actually I'm using xvimagesink over Xorg

And did you try to force software crop as suggested ? To confirm it's a
video sink issue ? I assumed it was wayland because I saw no
decoration, I guess this was just full screen.

Nicolas

_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/gstreamer-devel

[RiccardoCagnasso]

Yes, I tried as you suggested and it fixed the crop, but the framerate
dropped dramatically to around 1 frame per second.

I also tried to sobstitute "identity drop-allocation=1" with "videomixer"
and that fixed the crop without any visible performance degradation. I don't
have any idea why. It was just a hunch.



--
Sent from: http://gstreamer-devel.966125.n4.nabble.com/
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/gstreamer-devel

[Nicolas Dufresne-5]

Le dim. 1 sept. 2019 07 h 56, RiccardoCagnasso <[hidden email]> a écrit :

Yes, I tried as you suggested and it fixed the crop, but the framerate
dropped dramatically to around 1 frame per second.

I also tried to sobstitute "identity drop-allocation=1" with "videomixer"
and that fixed the crop without any visible performance degradation. I don't
have any idea why. It was just a hunch.

Your video source likely can't allocate at runtime, with too few buffers and software operations (higher processing delay) I often see this performance collapse in GStreamer.

Can you remind me which videosink has a bad video crop implementation, I'd like to reproduce and file an issue about it.

--
Sent from: http://gstreamer-devel.966125.n4.nabble.com/
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/gstreamer-devel

_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/gstreamer-devel

[RiccardoCagnasso]

My video source is a simple file, I'm not sure what you mean by "allocate at
runtime".

As a recap with video sources:

gst-launch-1.0 filesrc location=loop.mp4 ! qtdemux ! vaapidecodebin ! tee
name=t t. ! queue ! videocrop left=1920 ! xvimagesink t. ! queue ! videocrop
right=1920 ! xvimagesink <- has the crop bug
gst-launch-1.0 filesrc location=loop.mp4 ! qtdemux ! vaapidecodebin ! tee
name=t t. ! queue ! videocrop left=1920 ! ximagesink t. ! queue ! videocrop
right=1920 ! ximagesink <- has the crop bug
gst-launch-1.0 filesrc location=loop.mp4 ! qtdemux ! vaapidecodebin ! tee
name=t t. ! queue ! videocrop left=1920 ! glupload ! glimagesink t. ! queue
! videocrop right=1920 ! glupload ! glimagesink <- black screen
gst-launch-1.0 filesrc location=loop.mp4 ! qtdemux ! vaapidecodebin ! tee
name=t t. ! queue ! videocrop left=1920 ! videoconvert ! glupload !
gtkglsink t. ! queue ! videocrop right=1920 ! glupload ! gtkglsink <- works
(WHAT?) but only if using iHD as vaapi driver
gst-launch-1.0 filesrc location=loop.mp4 ! qtdemux ! vaapidecodebin ! tee
name=t t. ! queue ! videocrop left=1920 ! videoconvert ! vaapisink t. !
queue ! videocrop right=1920 ! vaapisink <- you can't apparently have two
vaapisinks in the same pipeline



--
Sent from: http://gstreamer-devel.966125.n4.nabble.com/
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/gstreamer-devel