ADV7280 capture

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

ADV7280 capture

Tim Harvey
Fabio,

Recently you mentioned you were capturing successfully using an
adv7280 analog video decoder on an imx6dl with 5.10.

I have found that using the adv7280 on an imx6q/dl does not work
without a patch [1] to make the output format of the adv7280 the same
as the adv7180. I'm not sure what the best solution for this issue is
as the patch was nak'd because it may break existing users of the
adv7280. I suspect perhaps the best approach is to add a kernel module
parameter or device-tree property to configure the adv7280 for
compatibility with the imx6 CSI.

I also still have to patch imx-media-csi.c to skip the first few
frames in order to sync properly on bt656 sources [2]. I'm also not
sure if this patch is perhaps acceptable upstream of of there is a
better solution.

I would have expected you to run into these issues as well?

Here is the media-ctl setup that I use:
media-ctl -l "'adv7180 0-0020':0 -> 'ipu1_csi1_mux':4[1]"
media-ctl -l "'ipu1_csi1_mux':5 -> 'ipu1_csi1':0[1]"
media-ctl -l "'ipu1_csi1':1 -> 'ipu1_vdic':0[1]"
media-ctl -l "'ipu1_vdic':2 -> 'ipu1_ic_prp':0[1]"
media-ctl -l "'ipu1_ic_prp':2 -> 'ipu1_ic_prpvf':0[1]"
media-ctl -l "'ipu1_ic_prpvf':1 -> 'ipu1_ic_prpvf capture':0[1]"
media-ctl -V "'adv7180 0-0020':0 [fmt:UYVY2X8/640x480 field:seq-tb]"
media-ctl -V "'ipu1_csi1_mux':5 [fmt:UYVY2X8/640x480]"
media-ctl -V "'ipu1_csi1':1 [fmt:AYUV32/640x480]"
media-ctl -V "'ipu1_vdic':2 [fmt:AYUV32/640x480 field:none]"
media-ctl -V "'ipu1_ic_prp':2 [fmt:AYUV32/640x480 field:none]"
media-ctl -V "'ipu1_ic_prpvf':1 [fmt:AYUV32/640x480 field:none]"
v4l2-ctl -d2 --set-fmt-video=field=none

gst-launch-1.0 v4l2src device=/dev/video2 ! kmssink:

Best Regards,

Tim
[1] - https://patchwork.kernel.org/project/linux-media/patch/20190827215539.1286-1-mmichilot@...
[2] - https://github.com/Gateworks/linux-imx6/commit/959fbd4
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/gstreamer-devel
Reply | Threaded
Open this post in threaded view
|

Re: ADV7280 capture

Fabio Estevam
Hi Tim,

On Wed, Dec 23, 2020 at 7:43 PM Tim Harvey <[hidden email]> wrote:
>
> Fabio,
>
> Recently you mentioned you were capturing successfully using an
> adv7280 analog video decoder on an imx6dl with 5.10.

What worked for me was to just launch the pipeline:

gst-launch-1.0 v4l2src device=/dev/video2 ! kmssink

after applying the following patch:
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=v5.10.2&id=9fe46e7946fca0e9444c1481fec01e7bdcf636ea

I could not test the image captured by the analog camera because I
don't have access to it yet.

I should probably get the camera in January and then I will be able to
test it. I will let you know how it goes.

> I have found that using the adv7280 on an imx6q/dl does not work
> without a patch [1] to make the output format of the adv7280 the same
> as the adv7180. I'm not sure what the best solution for this issue is
> as the patch was nak'd because it may break existing users of the
> adv7280. I suspect perhaps the best approach is to add a kernel module
> parameter or device-tree property to configure the adv7280 for
> compatibility with the imx6 CSI.

Thanks for the explanation. I will keep this in mind when I test the
camera capture via ADV7280.

> I also still have to patch imx-media-csi.c to skip the first few
> frames in order to sync properly on bt656 sources [2]. I'm also not
> sure if this patch is perhaps acceptable upstream of of there is a
> better solution.

Yes, I recall this one. It does help with the scrolling issues.

What about formally submitting this one for discussion?

> I would have expected you to run into these issues as well?

I believe I will run into these issues too. I will keep you posted
when I get a chance to test it.

Thanks for you help!

Fabio Estevam
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/gstreamer-devel
Reply | Threaded
Open this post in threaded view
|

Re: ADV7280 capture

Fabio Estevam
In reply to this post by Tim Harvey
Hi Tim,

I missed one comment:

On Wed, Dec 23, 2020 at 7:43 PM Tim Harvey <[hidden email]> wrote:

> I have found that using the adv7280 on an imx6q/dl does not work
> without a patch [1] to make the output format of the adv7280 the same
> as the adv7180. I'm not sure what the best solution for this issue is
> as the patch was nak'd because it may break existing users of the
> adv7280. I suspect perhaps the best approach is to add a kernel module
> parameter or device-tree property to configure the adv7280 for
> compatibility with the imx6 CSI.

Yes, a devicetree property may be a good approach to avoid potential
regressions.

In case you submit a patch for this, please keep me in Cc.

Thanks
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/gstreamer-devel