Fighting rewinds / pulseaudio crash - update

[David Henningsson]

So to recap a little on the fighting rewinds issue - the one that makes
pulseaudio crash due to spending too much time in RT prio, and with the
pulseaudio log filled with rewinds.

A month ago I provided five patches in total, two in gstreamer[1] and
three in pulseaudio.

GStreamer #1: we have the "don't start the stream until we have written
some samples" - this fix is in gstreamer HEAD, committed by Wim Taymans.

GStreamer #2: send larger packages by removing a strange limit to
gstreamer's "segment size". This fix has been posted to the
gstreamer-devel mailinglist, but not committed AFAIK. I'm attaching a
version of the patch which has proper git headers and against git head.

Both GStreamer fixes have recently been uploaded to Ubuntu Natty, the
development version of Ubuntu.

PulseAudio #1 and #2: I believe these should be applied to PulseAudio
upstream.

PulseAudio #3: A person with alias h31 helped out here, and noticed this
patch was the one causing a regression in Skype. While I haven't exactly
figured out why, I do notice that this patch could cause problems for
very short samples. So let's drop this one for the time being.

For reference I resend the three patches (one in GStreamer, two in
pulseaudio) that I would like to see applied.

--
David Henningsson, Canonical Ltd.
http://launchpad.net/~diwic

[1] Well, Wim Taymans has some credit for the helping out with the first
one.

------------------------------------------------------------------------------
Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
Finally, a world-class log management solution at an even better price-free!
Download using promo code Free_Logger_4_Dev2Dev. Offer expires
February 28th, so secure your free ArcSight Logger TODAY!
http://p.sf.net/sfu/arcsight-sfd2d
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gstreamer-devel

[David Henningsson]

On 2011-01-31 10:41, Colin Guthrie wrote:
> Thanks for the update David :)

You're welcome :-)

>> PulseAudio #1 and #2: I believe these should be applied to PulseAudio
>> upstream.
>
> OK, I think you've given it sufficient testing and exposer to confirm
> this. Can I just ask if these are "safe" if the corresponding gst fixes
> are not committed? (i.e. will GST generally bork or should it cope as
> well as currently without it's patches?)

Both are optimisations - gst patch only will be better than no patch at
all, and PA patch only will be better than no patch at all. Most people
will see it solved by either patch, but I guess that there are machines
so slow that you'll need both.

 > Also, master only or master+s-q
 > (I'm personally favouring the latter).

Me too.

--
David Henningsson, Canonical Ltd.
http://launchpad.net/~diwic

------------------------------------------------------------------------------
Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
Finally, a world-class log management solution at an even better price-free!
Download using promo code Free_Logger_4_Dev2Dev. Offer expires
February 28th, so secure your free ArcSight Logger TODAY!
http://p.sf.net/sfu/arcsight-sfd2d
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gstreamer-devel

[Arun Raghavan]

On Mon, 2011-01-31 at 06:07 +0100, David Henningsson wrote:
[...]
> GStreamer #2: send larger packages by removing a strange limit to
> gstreamer's "segment size". This fix has been posted to the
> gstreamer-devel mailinglist, but not committed AFAIK. I'm attaching a
> version of the patch which has proper git headers and against git head.

This one makes sense - could you please put this on Bugzilla?

Thanks,
Arun


------------------------------------------------------------------------------
Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
Finally, a world-class log management solution at an even better price-free!
Download using promo code Free_Logger_4_Dev2Dev. Offer expires
February 28th, so secure your free ArcSight Logger TODAY!
http://p.sf.net/sfu/arcsight-sfd2d
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gstreamer-devel

[Wim Taymans]

Well, I just commited it, but for the future it would be better to
attach patches to a  bugreport.

Wim

On Mon, Jan 31, 2011 at 5:02 PM, Arun Raghavan
<[hidden email]> wrote:

> On Mon, 2011-01-31 at 06:07 +0100, David Henningsson wrote:
> [...]
>> GStreamer #2: send larger packages by removing a strange limit to
>> gstreamer's "segment size". This fix has been posted to the
>> gstreamer-devel mailinglist, but not committed AFAIK. I'm attaching a
>> version of the patch which has proper git headers and against git head.
>
> This one makes sense - could you please put this on Bugzilla?
>
> Thanks,
> Arun
>
>
> ------------------------------------------------------------------------------
> Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
> Finally, a world-class log management solution at an even better price-free!
> Download using promo code Free_Logger_4_Dev2Dev. Offer expires
> February 28th, so secure your free ArcSight Logger TODAY!
> http://p.sf.net/sfu/arcsight-sfd2d
> _______________________________________________
> gstreamer-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/gstreamer-devel
>

------------------------------------------------------------------------------
Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
Finally, a world-class log management solution at an even better price-free!
Download using promo code Free_Logger_4_Dev2Dev. Offer expires
February 28th, so secure your free ArcSight Logger TODAY!
http://p.sf.net/sfu/arcsight-sfd2d
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gstreamer-devel

[David Henningsson]

On 2011-01-31 17:16, Wim Taymans wrote:
> Well, I just commited it, but for the future it would be better to
> attach patches to a  bugreport.

Ok, thanks. Coming from alsa-devel, I'm used to getting mailinglist
stuff being picked up and bug reports forgotten ;-)

Anyway, after having read Arun's mail but not yours, I created a bug:

https://bugzilla.gnome.org/show_bug.cgi?id=641072

...feel free to close it the way you like.

>
> Wim
>
> On Mon, Jan 31, 2011 at 5:02 PM, Arun Raghavan
> <[hidden email]>  wrote:
>> On Mon, 2011-01-31 at 06:07 +0100, David Henningsson wrote:
>> [...]
>>> GStreamer #2: send larger packages by removing a strange limit to
>>> gstreamer's "segment size". This fix has been posted to the
>>> gstreamer-devel mailinglist, but not committed AFAIK. I'm attaching a
>>> version of the patch which has proper git headers and against git head.
>>
>> This one makes sense - could you please put this on Bugzilla?
>>
>> Thanks,
>> Arun
>>
>>
>> ------------------------------------------------------------------------------
>> Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
>> Finally, a world-class log management solution at an even better price-free!
>> Download using promo code Free_Logger_4_Dev2Dev. Offer expires
>> February 28th, so secure your free ArcSight Logger TODAY!
>> http://p.sf.net/sfu/arcsight-sfd2d
>> _______________________________________________
>> gstreamer-devel mailing list
>> [hidden email]
>> https://lists.sourceforge.net/lists/listinfo/gstreamer-devel
>>
>
> ------------------------------------------------------------------------------
> Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
> Finally, a world-class log management solution at an even better price-free!
> Download using promo code Free_Logger_4_Dev2Dev. Offer expires
> February 28th, so secure your free ArcSight Logger TODAY!
> http://p.sf.net/sfu/arcsight-sfd2d
> _______________________________________________
> gstreamer-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/gstreamer-devel
>

--
David Henningsson, Canonical Ltd.
http://launchpad.net/~diwic

------------------------------------------------------------------------------
Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
Finally, a world-class log management solution at an even better price-free!
Download using promo code Free_Logger_4_Dev2Dev. Offer expires
February 28th, so secure your free ArcSight Logger TODAY!
http://p.sf.net/sfu/arcsight-sfd2d
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gstreamer-devel

[Stefan Sauer]

On 31.01.2011 18:16, Wim Taymans wrote:
> Well, I just commited it, but for the future it would be better to
> attach patches to a  bugreport.
what about pushing it?
Stefan

> Wim
>
> On Mon, Jan 31, 2011 at 5:02 PM, Arun Raghavan
> <[hidden email]> wrote:
>> On Mon, 2011-01-31 at 06:07 +0100, David Henningsson wrote:
>> [...]
>>> GStreamer #2: send larger packages by removing a strange limit to
>>> gstreamer's "segment size". This fix has been posted to the
>>> gstreamer-devel mailinglist, but not committed AFAIK. I'm attaching a
>>> version of the patch which has proper git headers and against git head.
>> This one makes sense - could you please put this on Bugzilla?
>>
>> Thanks,
>> Arun
>>
>>
>> ------------------------------------------------------------------------------
>> Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
>> Finally, a world-class log management solution at an even better price-free!
>> Download using promo code Free_Logger_4_Dev2Dev. Offer expires
>> February 28th, so secure your free ArcSight Logger TODAY!
>> http://p.sf.net/sfu/arcsight-sfd2d
>> _______________________________________________
>> gstreamer-devel mailing list
>> [hidden email]
>> https://lists.sourceforge.net/lists/listinfo/gstreamer-devel
>>
> ------------------------------------------------------------------------------
> Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
> Finally, a world-class log management solution at an even better price-free!
> Download using promo code Free_Logger_4_Dev2Dev. Offer expires
> February 28th, so secure your free ArcSight Logger TODAY!
> http://p.sf.net/sfu/arcsight-sfd2d
> _______________________________________________
> gstreamer-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/gstreamer-devel

------------------------------------------------------------------------------
Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
Finally, a world-class log management solution at an even better price-free!
Download using promo code Free_Logger_4_Dev2Dev. Offer expires
February 28th, so secure your free ArcSight Logger TODAY!
http://p.sf.net/sfu/arcsight-sfd2d
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gstreamer-devel