Fix for basic-tutorial-7.c (Simple multithreaded example)

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Fix for basic-tutorial-7.c (Simple multithreaded example)

Charlie Turner-2
I'm not sure where basic-tutorial-7.c lives, the tutorial itself says to
find it in my GStreamer installation, but I can't, nor in the git repo.

Anyway, I found I had to make this change to get it to run in 1.12.2,
perhaps a note could be added to the tut?

- tee_src_pad_template = gst_element_class_get_pad_template
(GST_ELEMENT_GET_CLASS (tee), "src_%d");
+ tee_src_pad_template = gst_element_class_get_pad_template
(GST_ELEMENT_GET_CLASS (tee), "src_%u");

(note it's s/src_%d/src_%u/)

BR,
--Charlie.
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/gstreamer-devel
Reply | Threaded
Open this post in threaded view
|

Re: Fix for basic-tutorial-7.c (Simple multithreaded example)

Sebastian Dröge-3
On Mon, 2017-09-04 at 12:40 +0100, Charlie Turner wrote:

> I'm not sure where basic-tutorial-7.c lives, the tutorial itself says
> to find it in my GStreamer installation, but I can't, nor in the git
> repo.
>
> Anyway, I found I had to make this change to get it to run in 1.12.2,
> perhaps a note could be added to the tut?
>
> - tee_src_pad_template = gst_element_class_get_pad_template
> (GST_ELEMENT_GET_CLASS (tee), "src_%d");
> + tee_src_pad_template = gst_element_class_get_pad_template
> (GST_ELEMENT_GET_CLASS (tee), "src_%u");
>
> (note it's s/src_%d/src_%u/)
I fixed that a while ago already:
https://cgit.freedesktop.org/gstreamer/gst-docs/commit/?id=1a9f0541be419798eacc6fedf50cadadebca352b

Is it still wrong on the website or somewhere?

--
Sebastian Dröge, Centricular Ltd · https://www.centricular.com

_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/gstreamer-devel

signature.asc (981 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Fix for basic-tutorial-7.c (Simple multithreaded example)

Tim-Philipp Müller-2
In reply to this post by Charlie Turner-2
On Mon, 2017-09-04 at 12:40 +0100, Charlie Turner wrote:

Hi Charlie,

Thanks for the fix. Please submit it as patch in bugzilla, thanks!

Cheers
 -Tim
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/gstreamer-devel
Reply | Threaded
Open this post in threaded view
|

Re: Fix for basic-tutorial-7.c (Simple multithreaded example)

Charlie Turner-2
In reply to this post by Sebastian Dröge-3
On 04/09/17 13:31, Sebastian Dröge wrote:
> I fixed that a while ago already:
> https://cgit.freedesktop.org/gstreamer/gst-docs/commit/?id=1a9f0541be419798eacc6fedf50cadadebca352b
>
> Is it still wrong on the website or somewhere?

Now I know where the repo is, thanks. It's still wrong on this page,

https://gstreamer.freedesktop.org/documentation/tutorials/basic/multithreading-and-pad-availability.html

Thanks for the tutorials, they have been very helpful.

BR,
--Charlie.

_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/gstreamer-devel