GStreamer-devel

Re: [gst-cvs] tpm gstreamer: gstreamer/ gstreamer/gst/

Classic

List

Threaded

3 messages Options

Stefan Sauer

Re: [gst-cvs] tpm gstreamer: gstreamer/ gstreamer/gst/

Hi tim,

[hidden email] schrieb:

> CVS Root: /cvs/gstreamer
> Module: gstreamer
> Changes by: tpm
> Date: Mon Mar 03 2008 14:43:41 UTC
>
> Log message:
> * configure.ac:
> * gst/gstconfig.h.in:
> * gst/gstregistry.h:
> Fix broken use of config.h-defined preprocessor directive in a public
> header file. Add a corresponding define to gstconfig.h, since we can't
> really remove those function declarations from the header file now
> (or can we? and why are they there in the first place?).
>
> Modified files:
> . : ChangeLog configure.ac
> gst : gstconfig.h.in gstregistry.h
>

you are right. headers should not use config.h values. With you change though I
get a build failure becasue of
> more docs/gst/gstreamer-unused.txt
GST_USING_BINARY_REGISTRY
Easy to fix. Should I file a core-blocker with patch?

Stefan

> Links:
> http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.3700&r2=1.3701
> http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/configure.ac.diff?r1=1.528&r2=1.529
> http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstconfig.h.in.diff?r1=1.28&r2=1.29
> http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstregistry.h.diff?r1=1.40&r2=1.41
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2008.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> _______________________________________________
> gstreamer-cvs mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/gstreamer-cvs

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gstreamer-devel

Stefan Sauer

Re: [gst-cvs] tpm gstreamer: gstreamer/ gstreamer/gst/

hi again,
Stefan Kost schrieb:

> Hi tim,
>
> [hidden email] schrieb:
>> CVS Root: /cvs/gstreamer
>> Module: gstreamer
>> Changes by: tpm
>> Date: Mon Mar 03 2008 14:43:41 UTC
>>
>> Log message:
>> * configure.ac:
>> * gst/gstconfig.h.in:
>> * gst/gstregistry.h:
>> Fix broken use of config.h-defined preprocessor directive in a public
>> header file. Add a corresponding define to gstconfig.h, since we can't
>> really remove those function declarations from the header file now
>> (or can we? and why are they there in the first place?).
>>
>> Modified files:
>> . : ChangeLog configure.ac
>> gst : gstconfig.h.in gstregistry.h
>>
>
> you are right. headers should not use config.h values. With you change though I
> get a build failure becasue of
>> more docs/gst/gstreamer-unused.txt
> GST_USING_BINARY_REGISTRY
> Easy to fix. Should I file a core-blocker with patch?
>
> Stefan

now also gst-python fails with:

cc1: warnings being treated as errors
gst.c: In function '_wrap_gst_registry_xml_read_cache':
gst.c:11875: warning: implicit declaration of function 'gst_registry_xml_read_cache'
gst.c: In function '_wrap_gst_registry_xml_write_cache':
gst.c:11891: warning: implicit declaration of function
'gst_registry_xml_write_cache'

Stefan

>
>> Links:
>> http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.3700&r2=1.3701
>> http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/configure.ac.diff?r1=1.528&r2=1.529
>> http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstconfig.h.in.diff?r1=1.28&r2=1.29
>> http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstregistry.h.diff?r1=1.40&r2=1.41
>>
>> -------------------------------------------------------------------------
>> This SF.net email is sponsored by: Microsoft
>> Defy all challenges. Microsoft(R) Visual Studio 2008.
>> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
>> _______________________________________________
>> gstreamer-cvs mailing list
>> [hidden email]
>> https://lists.sourceforge.net/lists/listinfo/gstreamer-cvs
>
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2008.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> _______________________________________________
> gstreamer-cvs mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/gstreamer-cvs

Tim-Philipp Müller-2

Re: [gst-cvs] tpm gstreamer: gstreamer/ gstreamer/gst/

In reply to this post by Stefan Sauer

On Wed, 2008-03-05 at 20:45 +0200, Stefan Kost wrote:

> you are right. headers should not use config.h values. With you change though I
> get a build failure becasue of
> > more docs/gst/gstreamer-unused.txt
> GST_USING_BINARY_REGISTRY
> Easy to fix. Should I file a core-blocker with patch?

Chances are that that will be more productive than spamming the mailing
list, so yes, please.

> now also gst-python fails with:
> cc1: warnings being treated as errors
> gst.c: In function '_wrap_gst_registry_xml_read_cache':
> gst.c:11875: warning: implicit declaration of function 'gst_registry_xml_read_cache'
> gst.c: In function '_wrap_gst_registry_xml_write_cache':
> gst.c:11891: warning: implicit declaration of function
> 'gst_registry_xml_write_cache'

That's either a bug in gst-python then that was never discovered or
fixed up for the binary registry case when the binary registry was
added, or the either/or declaration in the header was bogus in the
first place and we should just declare both read/write functions
regardless of which registry is actually used and add empty stubs
returning FALSE for the unused implementation to maintain full ABI/API
compatibility (I'm still not sure why/whether these functions are
exposed on purpose). The latter is probably less hassle, and we'll need
to do it anyway if we ever switch to the binary registry as default.
Dunno. File a bug.

Cheers
-Tim

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gstreamer-devel