h264parse don't handle pps_id more than 255

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

h264parse don't handle pps_id more than 255

Igor
I play h264 file with such pipeline:
appsrc ! h264parse ! mp4mux ! appsink .      Everything worked OK for a long
time, but once i got h264 file with pps_id > 255.

Gstreamer don't play such file, outputs error:


*WARN; 0;  /MP4Pipeline/App/GStreamer: codecparsers_h264
gsth264parser.c:1892:gst_h264_parse_pps:(NULL) value greater than max.
value: 509, max 255*

How can i fix that? May be there's alternative to h264parse.

Thanks!





--
Sent from: http://gstreamer-devel.966125.n4.nabble.com/
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/gstreamer-devel
Reply | Threaded
Open this post in threaded view
|

Re: h264parse don't handle pps_id more than 255

Gst-Geek

Maximum values of SPS and PPS IDs are set to
#define GST_H264_MAX_SPS_COUNT   32
#define GST_H264_MAX_PPS_COUNT   256
https://github.com/agx/gst-plugins-bad/blob/master/gst-libs/gst/codecparsers/gsth264parser.h

Change and rebuild gst-libs/gst/codecparsers and gst/videoparsers again.



--
Sent from: http://gstreamer-devel.966125.n4.nabble.com/
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/gstreamer-devel
Reply | Threaded
Open this post in threaded view
|

Re: h264parse don't handle pps_id more than 255

Nicolas Dufresne-5
In reply to this post by Igor
Le vendredi 09 novembre 2018 à 04:11 -0600, Igor a écrit :

> I play h264 file with such pipeline:
> appsrc ! h264parse ! mp4mux ! appsink .      Everything worked OK for a long
> time, but once i got h264 file with pps_id > 255.
>
> Gstreamer don't play such file, outputs error:
>
>
> *WARN; 0;  /MP4Pipeline/App/GStreamer: codecparsers_h264
> gsth264parser.c:1892:gst_h264_parse_pps:(NULL) value greater than max.
> value: 509, max 255*
>
> How can i fix that? May be there's alternative to h264parse.
>

Your encoder is producing something invalid, or some memory corruption
is happening. What 264parse does is perfectly correct. Here's what the
spec says:

   7.4.2.2
   Picture parameter set RBSP semantics
   pic_parameter_set_id identifies the picture parameter set that is
   referred to in the slice header. The value of
   pic_parameter_set_id shall be in the range of 0 to 255, inclusive.

Nicolas

_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/gstreamer-devel