[regression] refactor ebml-write to be more 0.11 friendly

[Alexey Fisher]

Hi René,
i have regression after:

commit 1b213d905ac2b9a1e015be6daf0dfeb92294154c
Author: René Stadler <[hidden email]>
Date:   Mon Oct 10 15:36:14 2011 +0200

     matroska: refactor ebml-write to be more 0.11 friendly

     Switching to a more 0.11-friendly pattern, where getting the
buffer's data
     pointer and setting the size many times is less natural. This is of
course i
     preparation to the upcoming port of the plugin.



i can't play any file produced after this patch. Easyest way to
reproduce it:
gst-launch videotestsrc num-buffers=100 ! vp8enc bitrate=100000 !
webmmux ! filesink location=test.webm

Regarding,
Alexey
_______________________________________________
gstreamer-devel mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/gstreamer-devel

[Tim-Philipp Müller-2]

On Sat, 2011-11-05 at 19:04 +0100, Alexey Fisher wrote:

> commit 1b213d905ac2b9a1e015be6daf0dfeb92294154c
>  (...)
>      matroska: refactor ebml-write to be more 0.11 friendly
>  (...)
>
> i can't play any file produced after this patch. Easyest way to
> reproduce it:
> gst-launch videotestsrc num-buffers=100 ! vp8enc bitrate=100000 !
> webmmux ! filesink location=test.webm

Could you file a bug in bugzilla please? Thanks!

 Cheers
 -Tim

_______________________________________________
gstreamer-devel mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/gstreamer-devel

[René Stadler-2]

Am 05.11.2011 19:04, schrieb Alexey Fisher:
> Hi René,
> i have regression after:
>
> commit 1b213d905ac2b9a1e015be6daf0dfeb92294154c
> Author: René Stadler <[hidden email]>
> Date: Mon Oct 10 15:36:14 2011 +0200
[...]

Hi,

thanks for the report. I just fixed it:

commit 2a139a28d9bf7be1e36876e9dab0cb35f6d31ca7

     matroskamux: fix regression causing malformed files

     This was caused by me in 1b213d. It seems I was too focused on
     0.11 when I did this and tested the wrong branch.

     The problem was reported by Alexey Fisher.

--René
_______________________________________________
gstreamer-devel mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/gstreamer-devel

[René Stadler]

On Sun, Nov 6, 2011 at 3:02 PM, Tim-Philipp Müller <[hidden email]> wrote:
[...]
> Could you file a bug in bugzilla please? Thanks!
[...]

No need to, I fixed it already (I sent a reply earlier, but from the
wrong email account, so the message is stuck for moderator approval).

--René
_______________________________________________
gstreamer-devel mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/gstreamer-devel